test: organize and add tests #377
Conversation
✅ Deploy Preview for robyn canceled.
|
AntoineRR
force-pushed
the
test-rework
branch
3 times, most recently
from
f4345f1
to
7284d58
Compare
|
Hey @AntoineRR 👋 Thanks for the PR - the |
|
Oh I didn't notice the precommit failing, I will fix that thanks |
AntoineRR
force-pushed
the
test-rework
branch
from
7284d58
to
49da0a2
Compare
| from utils import get | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Fix middleware request headers modification") |
There was a problem hiding this comment.
Yes, I started investigating it but I'm actually waiting for PR #375 to be merged because I think its new struct will help as we could make Request a pyclass and pass its instance to the middlewares (and routes) instead of a hashmap, and that should help fix this. We could also manipulate a true Request object in the routes and misslewares instead of a raw dict, which would be much nicer!
There was a problem hiding this comment.
Amazing work @AntoineRR ! 🔥 This PR must've required a lot of work.
I have a few questions and suggestions. Let me know what you think of them 😄
|
Thanks for the review ! 😉 I will go through it and let you know when I did the changes |
AntoineRR
force-pushed
the
test-rework
branch
2 times, most recently
from
bd38ea4
to
304a57d
Compare
|
PR updated @sansyrox 🙂 |
There was a problem hiding this comment.
@AntoineRR , all looks good! 😄
I just have one final comment.
AntoineRR
force-pushed
the
test-rework
branch
from
304a57d
to
83eeeaf
Compare
Description
I felt like the tests needed to be better organized, so it would be easier to write new tests and to check the unit test coverage. This PR does the following to achieve those goals:
utils.pyfile that helps with requesting endpoints, and checks the status code and global headers of the response./syncand async one with/asyncfor example)There is still room for improvements, like actually testing if the startup and shutdown handlers are executed, but I didn't figure out a way to test this properly for now.