Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a request object #61

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Create a request object #61

merged 2 commits into from
Aug 3, 2021

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Aug 2, 2021

This request creates a request object instead of referring to individual variables.

Also, set basis for middleware additions in the future.

@sansyrox sansyrox force-pushed the request_object branch 2 times, most recently from 2fc3562 to 5a48e0e Compare August 2, 2021 19:20
@JackThomson2
Copy link
Contributor

We should probably build the Hashmap outside the GIL to try and keep concurrency as high as possible

@sansyrox
Copy link
Member Author

sansyrox commented Aug 3, 2021

@JackThomson2 , yes absolutely. I will make the changes.

@sansyrox sansyrox merged commit 0551c63 into main Aug 3, 2021
@sansyrox sansyrox deleted the request_object branch August 3, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants