Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/link-retry #271

Merged
merged 2 commits into from May 17, 2019

Conversation

Projects
None yet
2 participants
@haritonasty
Copy link
Contributor

commented May 16, 2019

fixed retry logic with documentation example

@haritonasty haritonasty requested a review from DmitriVanGuard May 16, 2019

const max = operation.getContext().maxAttempts || 10000
return !!error && count < max && operation.getContext().isRetriable
const { isRetriable, maxAttempts } = operation.getContext()
const max = maxAttempts || 100

This comment has been minimized.

Copy link
@DmitriVanGuard

DmitriVanGuard May 16, 2019

Contributor

100 feels like a potential DDoS. Maybe better to lower it to 10?

This comment has been minimized.

Copy link
@haritonasty

haritonasty May 16, 2019

Author Contributor

agree

@DmitriVanGuard DmitriVanGuard self-requested a review May 16, 2019

@haritonasty haritonasty merged commit 5b58236 into master May 17, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@haritonasty haritonasty deleted the fix/link-retry branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.