From 5c1be077ec7f185ed671f61b65e7f4700825deab Mon Sep 17 00:00:00 2001 From: Young Date: Mon, 31 Oct 2022 17:51:46 +0800 Subject: [PATCH] feat: remove throttle for keydown handler (#132) * feat: remove throttle for keydown handler * Create tough-cooks-remain.md Co-authored-by: yangxingyuan <39261479+sanyuan0704@users.noreply.github.com> --- .changeset/tough-cooks-remain.md | 7 +++++++ packages/plugin-search/src/component/index.tsx | 5 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 .changeset/tough-cooks-remain.md diff --git a/.changeset/tough-cooks-remain.md b/.changeset/tough-cooks-remain.md new file mode 100644 index 00000000..775beca1 --- /dev/null +++ b/.changeset/tough-cooks-remain.md @@ -0,0 +1,7 @@ +--- +"@islandjs/plugin-search": patch +"@islandjs/plugin-backtop": patch +"islandjs": patch +--- + +feat: remove throttle for keydown handler diff --git a/packages/plugin-search/src/component/index.tsx b/packages/plugin-search/src/component/index.tsx index 60ec8ff2..29930174 100644 --- a/packages/plugin-search/src/component/index.tsx +++ b/packages/plugin-search/src/component/index.tsx @@ -3,7 +3,6 @@ import { ChangeEvent, useCallback, useEffect, useRef, useState } from 'react'; import type { MatchResultItem, PageSearcher } from '../logic/search'; import SearchSvg from '../assets/search.svg'; import LoadingSvg from '../assets/loading.svg'; -import { throttle } from 'lodash-es'; import { SuggestionContent } from './Suggestion'; const KEY_CODE = { @@ -59,7 +58,7 @@ export function Search( ); useEffect(() => { - const onKeyDown = throttle((e: KeyboardEvent) => { + const onKeyDown = (e: KeyboardEvent) => { switch (e.code) { case KEY_CODE.SEARCH: if ((e.ctrlKey || e.metaKey) && searchInputRef.current) { @@ -95,7 +94,7 @@ export function Search( default: break; } - }, 200); + }; document.addEventListener('keydown', onKeyDown); return () => { document.removeEventListener('keydown', onKeyDown);