From 2d48a570d2027c6556622b18f332d09fe00cb508 Mon Sep 17 00:00:00 2001 From: Nils Koenig Date: Thu, 18 Sep 2025 11:23:11 +0200 Subject: [PATCH 1/6] Documentation Update - Replaced relative links with absolute links. - Mark sap_vm_provision(kubevirt) as beta. - Mark sap_hypervisor_node_preconfigure(RHV) as deprecated. - Added info about testing. - removed unused dependency to community.okd. --- README.md | 4 +- .../README.md | 121 ++++++++++++++++-- roles/sap_vm_provision/README.md | 20 +-- 3 files changed, 122 insertions(+), 23 deletions(-) diff --git a/README.md b/README.md index 7df9c43..f2dd046 100644 --- a/README.md +++ b/README.md @@ -108,7 +108,7 @@ For information on how to contribute, please see our [contribution guidelines](h ## Contributors -You can find list of Contributors at [/docs/contributors](./docs/CONTRIBUTORS.md). +You can find list of Contributors at [/docs/contributors](https://github.com/sap-linuxlab/community.sap_infrastructure/tree/main/docs/CONTRIBUTORS.md). ## Support @@ -125,5 +125,5 @@ The release notes for this collection can be found in the [CHANGELOG file](https Please follow [Ansible Precedence guidelines](https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable) on how to pass variables when using this collection. -## License +## License Information [Apache 2.0](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/LICENSE) diff --git a/roles/sap_hypervisor_node_preconfigure/README.md b/roles/sap_hypervisor_node_preconfigure/README.md index c76131a..1802b66 100644 --- a/roles/sap_hypervisor_node_preconfigure/README.md +++ b/roles/sap_hypervisor_node_preconfigure/README.md @@ -1,3 +1,91 @@ +# Title of Collection + +The collection title should indicate, at a high level, what the collection is for. + +## Description + +In this section, give a high-level description of the collection including information about what the collection contains, why it is relevant, who should use it, and what it allows the user to do. This section is often referenced in marketing materials, so be sure to highlight any benefits of the collection and its purpose. + + +## Requirements + +This section must list the required minimum versions of Ansible and Python, and any Python or external collection dependencies. Include additional information on other prerequisite tasks needed, if applicable. + + +## Installation + +This section must not include details about installing Ansible or ansible-core as that is installed as part of the AAP installation and execution environments. This section should focus on installing the collection from automation hub and must not include references to installing from GitHub. + +Before using this collection, you need to install it with the Ansible Galaxy command-line tool: + +``` +ansible-galaxy collection install NAMESPACE.COLLECTION_NAME +``` + +You can also include it in a requirements.yml file and install it with ansible-galaxy collection install -r requirements.yml, using the format: + + +```yaml +collections: + - name: NAMESPACE.COLLECTION_NAME +``` + +To upgrade the collection to the latest available version, run the following command: + +``` +ansible-galaxy collection install NAMESPACE.COLLECTION_NAME --upgrade +``` + +You can also install a specific version of the collection. Use the following syntax to install version 1.0.0: + +``` +ansible-galaxy collection install NAMESPACE.COLLECTION_NAME:==1.0.0 +``` + +See [using Ansible collections](https://docs.ansible.com/ansible/devel/user_guide/collections_using.html) for more details. + + +In addition to the above boilerplate, this section should include any additional details specific to your collection, and what to expect at each step and after installation. Be sure to include any information that supports the installation process, such as information about authentication and credentialing. + +## Use Cases + +This section should outline in detail 3-5 common use cases for the collection. These should be informative examples of how the collection has been used, or how you’d like to see it be used. + + +## Testing + +This section should include information on how the collection was tested and how it performed. Include information on what environments it’s been tested against, and any known exceptions or workarounds necessary for its use. + + + +## Contributing (Optional) + +This section is optional, and provides a section to describe how to contribute to the collection. You can include, or link to, contribution guidelines that describe the process for contribution and a code of conduct for contributing to the collection and interacting with other contributors. This section should also include contact information or links to community channels for discussion. All links must be full URLs, not GitHub relative links. + + +## Support + +This section should include information about what is supported and how to get support for the collection. This can include supported versions of the collection, how to submit a support request, and any other information about how to get additional assistance. We recommend the following text for certified content only: + +As Red Hat Ansible Certified Content, this collection is entitled to support through the Ansible Automation Platform (AAP) using the **Create issue** button on the top right corner. If a support case cannot be opened with Red Hat and the collection has been obtained either from Galaxy or GitHub, there may community help available on the [Ansible Forum](https://forum.ansible.com/). + + +## Release Notes and Roadmap + +Collections must link to their release notes or changelog. Collections that have a public roadmap available should also link to that. All links must be full URLs, not GitHub relative links. Private repositories can include this information in their README file, or include the file in the collection tarball. Collections can optionally add a release note or changelog file to the docs/ directory as simplified markdown to display this information in automation hub. + + +## Related Information + +Where available, link to general how to use collections or other related documentation applicable to the technology/product this collection works with. Useful materials such as demos, case studies, etc. may be linked here as well. All links must be full URLs, not GitHub relative links. + + +## License Information + +Link to the license that the collection is published under. All links must be full URLs, not GitHub relative links. For private repositories, mention the license used in this README and that the user can find the license included in the downloaded collection. + + +---------------------------------------------------------------------------------------------------------- `Beta` @@ -58,7 +146,7 @@ Configures the Red Hat OpenShift cluster for SAP workloads. - For SAP HANA: Worker nodes with Intel CPU Instruction Sets: `TSX` ([SAP Note 2737837](https://me.sap.com/notes/2737837/E)) ### Control Node Requirements -For a list of all collection prerequisites, please see the [Ansible Collection Readme](../../README.md#requirements). +For a list of all collection prerequisites, please see the [Ansible Collection Readme](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/README.md#requirements). Direct access to the Red Hat OpenShift cluster is required. - An Ansible Automation Platform Controller can be used to facilitate the orchestration. @@ -70,30 +158,28 @@ Direct access to the Red Hat OpenShift cluster is required. - `kubernetes` >= 29.0.0 - Ansible Collections: - `kubernetes.core` >= 3.0.0 - - `community.okd` >= 3.0.1 ### Platform Specific Variables -All platform specific variables are available in [vars/platform_defaults_redhat_ocp_virt.yml](vars/platform_defaults_redhat_ocp_virt.yml). +All platform specific variables are available in [vars/platform_defaults_redhat_ocp_virt.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/roles/sap_hypervisor_node_preconfigure/vars/platform_defaults_redhat_ocp_virt.yml). The `kubeconfig` configuration file has to be provided by either: 1. The Ansible variable `sap_hypervisor_node_kubeconfig`. 2. The environment variable `K8S_AUTH_KUBECONFIG`. 3. The environment variable `KUBECONFIG`. -**NOTE:** If using the trident storage operator, the `kubeconfig` has also to contain a valid API token. +**NOTE:** If using the trident storage operator, the `kubeconfig` file has also to contain a valid API token. Every worker has to have an entry in the `workers` section of the variable `sap_hypervisor_node_preconfigure_cluster_config` and make sure, that the name attribute corresponds with the cluster node name (e.g. worker-0). Adjust the network interface name you want to use. There are two types of networking technologies available: bridging or SR-IOV. There is a section for the `trident` configuration, this is required when installing the NetApp Astra Trident Operator for NFS storage. When using the host path provisioner, `worker_localstorage_device` has to point to the block device which should be used. ### Example -See [sample-sap-hypervisor-redhat_ocp_virt-preconfigure.yml](../playbooks/sample-sap-hypervisor-redhat_ocp_virt-preconfigure.yml) for an example. +See [sample-sap-hypervisor-redhat_ocp_virt-preconfigure.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/playbooks/sample-sap-hypervisor-redhat_ocp_virt-preconfigure.yml) for an example. Make sure to set the `K8S_AUTH_KUBECONFIG` environment variable, e.g. ``` export K8S_AUTH_KUBECONFIG=/path/to/my_kubeconfig ``` -To invoke the example playbook with the example configuration using your localhost as ansible host use this command: -- It has to be executed from [`/playbooks`](../playbooks/) directory. +To invoke the example playbook with the example configuration using your localhost as ansible host use the following command. In this example it has to be executed from `/playbooks` directory, otherwise the path hast to be adjusted. ```shell ansible-playbook --connection=local -i localhost, \ @@ -102,7 +188,7 @@ ansible-playbook --connection=local -i localhost, \ ``` -## Platform: Red Hat Virtualization (RHV) +## Platform: Red Hat Virtualization (RHV) `deprecated` Configures the Red Hat Virtualization (RHV) hypervisor nodes, formerly known as Red Hat Enterprise Virtualization (RHEV) prior to version 4.4. Red Hat Virtualization consists of a `Red Hat Virtualization Manager (RHV-M)` and the `Red Hat Virtualization Host (RHV-H)` hypervisor nodes that this role pre-configures. @@ -112,22 +198,31 @@ This Ansible Role does not preconfigure RHEL KVM (RHEL-KVM) hypervisor nodes. - Please note that RHEL KVM is a standalone hypervisor and does not include the management tooling provided by RHV-M. ### Requirements -For a list of all collection prerequisites, please see the [Ansible Collection Readme](../../README.md#requirements). +For a list of all collection prerequisites, please see the [Ansible Collection Readme](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/README.md#requirements). - Hypervisor Administrator credentials - One or more available RHV hypervisors. ### Platform Specific Variables -All platform specific variables are available in [vars/platform_defaults_redhat_rhel_kvm.yml](vars/platform_defaults_redhat_rhel_kvm.yml). +All platform specific variables are available in [vars/platform_defaults_redhat_rhel_kvm.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/roles/sap_hypervisor_node_preconfigure/vars/platform_defaults_redhat_rhel_kvm.yml). ### Example -See [sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml](../playbooks/sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml) for an example. +See [sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/playbooks/sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml) for an example. -## License +## Testing +The `sap_hypervisor_node_preconfigure` roles is continuously tested for Red Hat OpenShift. Goal is to ensure that this roles work on all supported OpenShift versions. All network related setup is tested with ipv4 only. + +## Contributing +You can find more information about ways you can contribute at [sap-linuxlab website](https://sap-linuxlab.github.io/initiative_contributions/). + +## Support +You can report any issues using [Issues](https://github.com/sap-linuxlab/community.sap_infrastructure/issues) section. + +## License Information Apache 2.0 @@ -139,6 +234,6 @@ Apache 2.0 ## Role Variables -The list of all available variables: [/defaults parameters file](./defaults/main.yml). +The list of all available variables: [/defaults parameters file](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/roles/sap_hypervisor_node_preconfigure/vars/platform_defaults_redhat_rhel_kvm.yml). The platform specific variables are defined in their respective files under `vars/` directory. \ No newline at end of file diff --git a/roles/sap_vm_provision/README.md b/roles/sap_vm_provision/README.md index b1cc74d..6fa269a 100644 --- a/roles/sap_vm_provision/README.md +++ b/roles/sap_vm_provision/README.md @@ -20,7 +20,7 @@ This Ansible Role follows requirements and best practices of each Infrastructure ## Prerequisites (Control Node) The prerequisites are listed only for Control Node, because Managed Nodes are provisioned during runtime. -For a list of requirements and recommended authorizations on each Infrastructure Platform, please see the separate [Infrastructure Platform Guidance](./PLATFORM_GUIDANCE.md) document and the drop-down for each different Infrastructure Platform. +For a list of requirements and recommended authorizations on each Infrastructure Platform, please see the separate [Infrastructure Platform Guidance](https://github.com/sap-linuxlab/community.sap_infrastructure/tree/main/roles/sap_vm_provision/PLATFORM_GUIDANCE.md) document and the drop-down for each different Infrastructure Platform. ### Base Prerequisites For list of all collection prerequisites, please see [Ansible Collection Readme](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/README.md#requirements) @@ -33,8 +33,8 @@ For list of all collection prerequisites, please see [Ansible Collection Readme] - `passlib` 1.7 or higher - `jmespath` 1.0.1 or higher - Ansible Collections: - - `cloud.common` - - `cloud.terraform` When `Ansible to Terraform` is used. + - `cloud.common` + - `cloud.terraform` when `Ansible to Terraform` is used. ### Amazon Web Services (AWS) Prerequisites - Python libraries and modules: @@ -103,7 +103,7 @@ A series of choices are deciding Ansible Role behavior: - Microsoft Azure Virtual Machines - IBM PowerVM Virtual Machines _(formerly LPAR)_ - OVirt Virtual Machines `[Experimental]` -- KubeVirt Virtual Machines `[Experimental]` (e.g. Red Hat OpenShift Virtualization) +- KubeVirt Virtual Machines `[beta]` (e.g. Red Hat OpenShift Virtualization) - VMware vSphere Virtual Machines `[Experimental]` @@ -167,12 +167,15 @@ Explanation of workflow: 3. Third play: `Ansible Play for remaining tasks on provisioned hosts` - Example of how newly provisioned hosts can be targeted with additional tasks (e.g. SAP Installation). -For further information, see the [sample Ansible Playbooks in `/playbooks`](../playbooks/). +For further information, see the [sample Ansible Playbooks in `/playbooks`](https://github.com/sap-linuxlab/community.sap_infrastructure/tree/main/playbooks/). +## Testing +The `sap_vm_provision` roles is continuously tested for Red Hat OpenShift. Goal is to ensure that this roles work on all supported OpenShift versions. All network related setup is tested with ipv4 only. + ## Further Information - For Hyperscaler Cloud Service Providers that use Resource Groups (IBM Cloud, Microsoft Azure): @@ -182,9 +185,10 @@ For further information, see the [sample Ansible Playbooks in `/playbooks`](../p ### Known issues - VMware REST API combined with cloud-init is unstable, `userdata` configuration may not execute and provisioning will fail +- On a kubevirt platfrom (e.g. Red Hat OpenShift) `ANSIBLE_JINJA2_NATIVE=true` has to be set in the environment. -## License +## License Information Apache 2.0 @@ -198,7 +202,7 @@ Apache 2.0 ## Role Variables -The list of all available variables: [/defaults parameters file](./defaults/main.yml). +The list of all available variables: [/defaults parameters file](https://github.com/sap-linuxlab/community.sap_infrastructure/tree/main/roles/sap_vm_provision/defaults/main.yml). **Following key variables are required.** @@ -238,7 +242,7 @@ Customization options:
### Credentials -Each Infrastructure Platform has list of required variables defined in [/defaults parameters file](./defaults/main.yml). +Each Infrastructure Platform has list of required variables defined in [/defaults parameters file](https://github.com/sap-linuxlab/community.sap_infrastructure/tree/main/roles/sap_vm_provision/defaults/main.yml). Example for `aws_ec2_vs`: - `sap_vm_provision_aws_access_key` - `sap_vm_provision_aws_secret_access_key` From 64111b035ad1829908fae92f103c1930e9d9141d Mon Sep 17 00:00:00 2001 From: Nils Koenig Date: Thu, 18 Sep 2025 11:28:00 +0200 Subject: [PATCH 2/6] fixed typo --- roles/sap_vm_provision/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/sap_vm_provision/README.md b/roles/sap_vm_provision/README.md index 6fa269a..8765602 100644 --- a/roles/sap_vm_provision/README.md +++ b/roles/sap_vm_provision/README.md @@ -185,7 +185,7 @@ The `sap_vm_provision` roles is continuously tested for Red Hat OpenShift. Goal ### Known issues - VMware REST API combined with cloud-init is unstable, `userdata` configuration may not execute and provisioning will fail -- On a kubevirt platfrom (e.g. Red Hat OpenShift) `ANSIBLE_JINJA2_NATIVE=true` has to be set in the environment. +- On a kubevirt platform (e.g. Red Hat OpenShift) `ANSIBLE_JINJA2_NATIVE=true` has to be set in the environment. ## License Information From 9354c93f4961ce2cd2a155df2f3405565bc70efa Mon Sep 17 00:00:00 2001 From: Nils Koenig Date: Thu, 18 Sep 2025 11:46:58 +0200 Subject: [PATCH 3/6] requested chages --- README.md | 2 +- .../README.md | 92 +------------------ roles/sap_vm_provision/README.md | 2 +- 3 files changed, 4 insertions(+), 92 deletions(-) diff --git a/README.md b/README.md index f2dd046..3db07e8 100644 --- a/README.md +++ b/README.md @@ -125,5 +125,5 @@ The release notes for this collection can be found in the [CHANGELOG file](https Please follow [Ansible Precedence guidelines](https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable) on how to pass variables when using this collection. -## License Information +## License [Apache 2.0](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/LICENSE) diff --git a/roles/sap_hypervisor_node_preconfigure/README.md b/roles/sap_hypervisor_node_preconfigure/README.md index 1802b66..993b5af 100644 --- a/roles/sap_hypervisor_node_preconfigure/README.md +++ b/roles/sap_hypervisor_node_preconfigure/README.md @@ -1,91 +1,3 @@ -# Title of Collection - -The collection title should indicate, at a high level, what the collection is for. - -## Description - -In this section, give a high-level description of the collection including information about what the collection contains, why it is relevant, who should use it, and what it allows the user to do. This section is often referenced in marketing materials, so be sure to highlight any benefits of the collection and its purpose. - - -## Requirements - -This section must list the required minimum versions of Ansible and Python, and any Python or external collection dependencies. Include additional information on other prerequisite tasks needed, if applicable. - - -## Installation - -This section must not include details about installing Ansible or ansible-core as that is installed as part of the AAP installation and execution environments. This section should focus on installing the collection from automation hub and must not include references to installing from GitHub. - -Before using this collection, you need to install it with the Ansible Galaxy command-line tool: - -``` -ansible-galaxy collection install NAMESPACE.COLLECTION_NAME -``` - -You can also include it in a requirements.yml file and install it with ansible-galaxy collection install -r requirements.yml, using the format: - - -```yaml -collections: - - name: NAMESPACE.COLLECTION_NAME -``` - -To upgrade the collection to the latest available version, run the following command: - -``` -ansible-galaxy collection install NAMESPACE.COLLECTION_NAME --upgrade -``` - -You can also install a specific version of the collection. Use the following syntax to install version 1.0.0: - -``` -ansible-galaxy collection install NAMESPACE.COLLECTION_NAME:==1.0.0 -``` - -See [using Ansible collections](https://docs.ansible.com/ansible/devel/user_guide/collections_using.html) for more details. - - -In addition to the above boilerplate, this section should include any additional details specific to your collection, and what to expect at each step and after installation. Be sure to include any information that supports the installation process, such as information about authentication and credentialing. - -## Use Cases - -This section should outline in detail 3-5 common use cases for the collection. These should be informative examples of how the collection has been used, or how you’d like to see it be used. - - -## Testing - -This section should include information on how the collection was tested and how it performed. Include information on what environments it’s been tested against, and any known exceptions or workarounds necessary for its use. - - - -## Contributing (Optional) - -This section is optional, and provides a section to describe how to contribute to the collection. You can include, or link to, contribution guidelines that describe the process for contribution and a code of conduct for contributing to the collection and interacting with other contributors. This section should also include contact information or links to community channels for discussion. All links must be full URLs, not GitHub relative links. - - -## Support - -This section should include information about what is supported and how to get support for the collection. This can include supported versions of the collection, how to submit a support request, and any other information about how to get additional assistance. We recommend the following text for certified content only: - -As Red Hat Ansible Certified Content, this collection is entitled to support through the Ansible Automation Platform (AAP) using the **Create issue** button on the top right corner. If a support case cannot be opened with Red Hat and the collection has been obtained either from Galaxy or GitHub, there may community help available on the [Ansible Forum](https://forum.ansible.com/). - - -## Release Notes and Roadmap - -Collections must link to their release notes or changelog. Collections that have a public roadmap available should also link to that. All links must be full URLs, not GitHub relative links. Private repositories can include this information in their README file, or include the file in the collection tarball. Collections can optionally add a release note or changelog file to the docs/ directory as simplified markdown to display this information in automation hub. - - -## Related Information - -Where available, link to general how to use collections or other related documentation applicable to the technology/product this collection works with. Useful materials such as demos, case studies, etc. may be linked here as well. All links must be full URLs, not GitHub relative links. - - -## License Information - -Link to the license that the collection is published under. All links must be full URLs, not GitHub relative links. For private repositories, mention the license used in this README and that the user can find the license included in the downloaded collection. - - ----------------------------------------------------------------------------------------------------------- `Beta` @@ -222,7 +134,7 @@ You can find more information about ways you can contribute at [sap-linuxlab web ## Support You can report any issues using [Issues](https://github.com/sap-linuxlab/community.sap_infrastructure/issues) section. -## License Information +## License Apache 2.0 @@ -236,4 +148,4 @@ Apache 2.0 The list of all available variables: [/defaults parameters file](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/roles/sap_hypervisor_node_preconfigure/vars/platform_defaults_redhat_rhel_kvm.yml). The platform specific variables are defined in their respective files under `vars/` directory. - \ No newline at end of file + diff --git a/roles/sap_vm_provision/README.md b/roles/sap_vm_provision/README.md index 8765602..0c0d2b1 100644 --- a/roles/sap_vm_provision/README.md +++ b/roles/sap_vm_provision/README.md @@ -188,7 +188,7 @@ The `sap_vm_provision` roles is continuously tested for Red Hat OpenShift. Goal - On a kubevirt platform (e.g. Red Hat OpenShift) `ANSIBLE_JINJA2_NATIVE=true` has to be set in the environment. -## License Information +## License Apache 2.0 From af52f39bb04fbbb3a9459932b0aabb06bbd4e705 Mon Sep 17 00:00:00 2001 From: Nils Koenig Date: Thu, 18 Sep 2025 12:22:12 +0200 Subject: [PATCH 4/6] Adjusted testing statement, removed Contributing, Support where it did not belong --- roles/sap_hypervisor_node_preconfigure/README.md | 10 ++-------- roles/sap_vm_provision/README.md | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/roles/sap_hypervisor_node_preconfigure/README.md b/roles/sap_hypervisor_node_preconfigure/README.md index 993b5af..aceea78 100644 --- a/roles/sap_hypervisor_node_preconfigure/README.md +++ b/roles/sap_hypervisor_node_preconfigure/README.md @@ -11,7 +11,7 @@ The Ansible Role `sap_hypervisor_node_preconfigure` configures hypervisor nodes This Ansible role supports the following hypervisors: - Red Hat OpenShift Virtualization (OCPV): 4.14 or higher -- Red Hat Enterprise Virtualization (RHV): 4.4 or higher +- Red Hat Enterprise Virtualization (RHV) `deprecated`: 4.4 or higher - _Formerly called Red Hat Enterprise Virtualization (RHEV) prior to version 4.4_ - _Note: This role is not compatible with standalone RHEL KVM (RHEL-KVM) hypervisor nodes._ @@ -126,13 +126,7 @@ See [sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml](https://github.com/ ## Testing -The `sap_hypervisor_node_preconfigure` roles is continuously tested for Red Hat OpenShift. Goal is to ensure that this roles work on all supported OpenShift versions. All network related setup is tested with ipv4 only. - -## Contributing -You can find more information about ways you can contribute at [sap-linuxlab website](https://sap-linuxlab.github.io/initiative_contributions/). - -## Support -You can report any issues using [Issues](https://github.com/sap-linuxlab/community.sap_infrastructure/issues) section. +Additionally the Ansible Role `sap_hypervisor_node_preconfigure` is continuously tested for Red Hat OpenShift. Goal is to ensure that this roles work on all supported OpenShift versions. All network related setup is tested with ipv4 only. ## License diff --git a/roles/sap_vm_provision/README.md b/roles/sap_vm_provision/README.md index 0c0d2b1..6ec2e59 100644 --- a/roles/sap_vm_provision/README.md +++ b/roles/sap_vm_provision/README.md @@ -174,7 +174,7 @@ For further information, see the [sample Ansible Playbooks in `/playbooks`](http ## Testing -The `sap_vm_provision` roles is continuously tested for Red Hat OpenShift. Goal is to ensure that this roles work on all supported OpenShift versions. All network related setup is tested with ipv4 only. +Additionally the Ansible Role `sap_vm_provision` is continuously tested for Red Hat OpenShift. Goal is to ensure that this roles work on all supported OpenShift versions. All network related setup is tested with ipv4 only. ## Further Information From f8d2d0879570f8e8b76dd45dfe0f27bf6703bdec Mon Sep 17 00:00:00 2001 From: Nils Koenig Date: Mon, 22 Sep 2025 15:43:50 +0200 Subject: [PATCH 5/6] fixed typo in URL, removed example to nonexisting playbook (RHV) --- roles/sap_hypervisor_node_preconfigure/README.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/roles/sap_hypervisor_node_preconfigure/README.md b/roles/sap_hypervisor_node_preconfigure/README.md index aceea78..bbba707 100644 --- a/roles/sap_hypervisor_node_preconfigure/README.md +++ b/roles/sap_hypervisor_node_preconfigure/README.md @@ -85,7 +85,7 @@ Every worker has to have an entry in the `workers` section of the variable `sap_ There is a section for the `trident` configuration, this is required when installing the NetApp Astra Trident Operator for NFS storage. When using the host path provisioner, `worker_localstorage_device` has to point to the block device which should be used. ### Example -See [sample-sap-hypervisor-redhat_ocp_virt-preconfigure.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/playbooks/sample-sap-hypervisor-redhat_ocp_virt-preconfigure.yml) for an example. +See [sample-sap-hypervisor-redhat-ocp-virt-preconfigure.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/playbooks/sample-sap-hypervisor-redhat-ocp-virt-preconfigure.yml) for an example. Make sure to set the `K8S_AUTH_KUBECONFIG` environment variable, e.g. ``` @@ -118,10 +118,6 @@ For a list of all collection prerequisites, please see the [Ansible Collection R ### Platform Specific Variables All platform specific variables are available in [vars/platform_defaults_redhat_rhel_kvm.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/roles/sap_hypervisor_node_preconfigure/vars/platform_defaults_redhat_rhel_kvm.yml). -### Example -See [sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml](https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/playbooks/sample-sap-hypervisor-redhat-rhel-kvm-preconfigure.yml) for an example. - - From 12939bc9dda8c944af0be32a6b6601bc327dee61 Mon Sep 17 00:00:00 2001 From: Nils Koenig Date: Mon, 22 Sep 2025 16:53:15 +0200 Subject: [PATCH 6/6] removed additional whitespace --- roles/sap_vm_provision/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/sap_vm_provision/README.md b/roles/sap_vm_provision/README.md index 6ec2e59..9a7914d 100644 --- a/roles/sap_vm_provision/README.md +++ b/roles/sap_vm_provision/README.md @@ -33,7 +33,7 @@ For list of all collection prerequisites, please see [Ansible Collection Readme] - `passlib` 1.7 or higher - `jmespath` 1.0.1 or higher - Ansible Collections: - - `cloud.common` + - `cloud.common` - `cloud.terraform` when `Ansible to Terraform` is used. ### Amazon Web Services (AWS) Prerequisites