Skip to content

collection: Add ansible-test sanity workflow and fix sanity errors #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

collection: Add ansible-test sanity workflow and fix sanity errors #55

merged 3 commits into from
Oct 8, 2025

Conversation

@marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Oct 8, 2025 •
edited
Loading

Changes

Update github workflows for latest linting and add sanity checks in alignment with sap-linuxlab/community.sap_install#1118

  • Linting was updated to align with rest of project
  • Linting workflow for role was added
  • Sanity workflow was added with additional EOL matrix
    • This is mandatory to avoid running Sanity test for 2.14 - 2.17 on Python 2.7 which would fail.
  • Sanity errors were resolved.

Tested

All modules were tested on:

  • Python 3.11 with ansible-core 2.18
  • Python 3.13 with ansible-core 2.19

@marcelmamula marcelmamula self-assigned this Oct 8, 2025
@marcelmamula marcelmamula added the enhancement New feature or request label Oct 8, 2025
berndfinger
berndfinger approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula merged commit f1e0216 into sap-linuxlab:dev Oct 8, 2025
16 checks passed
@marcelmamula marcelmamula mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berndfinger berndfinger berndfinger approved these changes

Assignees

@marcelmamula marcelmamula

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcelmamula @berndfinger