refactor remove duplicates, move to utils, add tests

internal/storage/elasticsearch.go

@@ -327,19 +327,6 @@ func (es ElasticSearch) GetAttributes(filter *AttributeFilter, tenantID string)
 	return unique, nil
 }
 
-// RemoveDuplicates removes duplicates from a slice of strings while preserving the order.
-func RemoveDuplicates(s []string) []string {
-	seen := make(map[string]struct{}, len(s))
-	var result []string
-	for _, v := range s {
-		if _, ok := seen[v]; !ok {
-			seen[v] = struct{}{}
-			result = append(result, v)
-		}
-	}
-	return result
-}
-
 // MaxLimit grabs the configured maxlimit for results
 func (es ElasticSearch) MaxLimit() uint {
 	return uint(viper.GetInt("elasticsearch.max_result_window"))

internal/storage/util.go

@@ -0,0 +1,15 @@
+package storage
+
+// RemoveDuplicates removes duplicates from a slice of strings while preserving the order.
+func RemoveDuplicates(s []string) []string {
+	seen := make(map[string]struct{}, len(s))
+	var result []string
+	for _, v := range s {
+		if _, ok := seen[v]; !ok {
+			seen[v] = struct{}{}
+			result = append(result, v)
+		}
+	}
+
+	return result
+}

internal/storage/util_test.go

@@ -0,0 +1,44 @@
+package storage
+
+import (
+	"reflect"
+	"testing"
+)
+
+func TestRemoveDuplicates(t *testing.T) {
+	tests := []struct {
+		name     string
+		input    []string
+		expected []string
+	}{
+		{
+			name:     "No duplicates",
+			input:    []string{"apple", "banana", "cherry"},
+			expected: []string{"apple", "banana", "cherry"},
+		},
+		{
+			name:     "With duplicates",
+			input:    []string{"apple", "banana", "cherry", "apple", "cherry"},
+			expected: []string{"apple", "banana", "cherry"},
+		},
+		{
+			name:     "All duplicates",
+			input:    []string{"apple", "apple", "apple"},
+			expected: []string{"apple"},
+		},
+		{
+			name:     "Single element",
+			input:    []string{"apple"},
+			expected: []string{"apple"},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			output := RemoveDuplicates(tt.input)
+			if !reflect.DeepEqual(output, tt.expected) {
+				t.Errorf("got %v, want %v", output, tt.expected)
+			}
+		})
+	}
+}