Fix panic when Affinity.New receives a nil config

sapcc · Oct 2, 2023 · 3146c52 · 3146c52
1 parent 7dd5429
commit 3146c52
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/plugin/impl/affinity.go b/plugin/impl/affinity.go
@@ -40,6 +40,9 @@ type Affinity struct {
 
 // New creates a new Affinity instance with the given config.
 func (a *Affinity) New(config *ucfgwrap.Config) (plugin.Checker, error) {
+	if config == nil {
+		return &Affinity{}, nil
+	}
 	conf := struct {
 		MinOperational int `config:"minOperational"`
 	}{}

diff --git a/plugin/impl/affinity_test.go b/plugin/impl/affinity_test.go
@@ -47,4 +47,11 @@ var _ = Describe("The Affinity plugin", func() {
 		Expect(plugin.(*Affinity).MinOperational).To(Equal(0))
 	})
 
+	It("can initialize when config is nil", func() {
+		var base Affinity
+		plugin, err := base.New(nil)
+		Expect(err).To(Succeed())
+		Expect(plugin.(*Affinity).MinOperational).To(Equal(0))
+	})
+
 })