Update installation docs #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs now reflect the fact that clang is a depency. Bin target renamed from sapio-cli to cli.
|
what platform is this? on mine it's still sapio-cli? |
|
What directory are you building from? if you look at the Cargo.toml it should be sapio-cli binary name |
|
Ah! But if you checkout v0.1.4 (The optional step) then cargo.toml has just Line 2 in db57f17 Not sure how to proceed with this PR now. |
|
I will release a new version soon to fix this :) good catch! |
drop the cli renaming; keep the clang hint? |
|
closing for now, not sure if still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
clanginstalled is a prerequisite, so I've added that to the installation docs.Also
cargo run --bin sapio-cliyielded the following error:I think the bin target should just be plain
cli. That made it work for me.