Conversation
|
Hi @sjvans, as CDS 4.4.4 is already available I've gave it a try. But it seems that your change doesn't work completely yet. Your original correction fails with:
as this.dbc isn't initialized. Changing it to0: this.on(['BEGIN', 'COMMIT', 'ROLLBACK'], async function (req) {
if (!this.dbc && req.event === 'BEGIN') {
this.dbc = await this.acquire(req)
}
return this.dbc.query(req.event)
})doesn't solve it as the connection seems not to be released. But with our original code we currently get "Release called on client which has already been released to the pool.". Best regards |
| @@ -63,7 +63,7 @@ | |||
| "supertest": "^6.0.1", | |||
| "uuidv4": "^6.2.4" | |||
| }, | |||
| "husky": { | |||
| "_husky": { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not simply deactivate husky. Please check out CONTRIBUTING.md#other-thingies how to format commit messages to be OK for the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONTRIBUTING.md#other-thingies
hi @gregorwolf
the pr was only meant as pointer, not as contribution ;)
tests are running now (cf. require of deploy), but an expect is not fulfilled anymore...
|
OK, I've created #77 which includes this changes. |
|
Hello |
please try the latest release. |
|
All fixed thanks for providing a quick fix. |
hi @gregorwolf this looks like a compatibility issue between cds and cds-runtime. i.e., if you do an npm install now with best, |
No description provided.