New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$base-line-height defined with a broken !default modifier #367

Closed
luismreis opened this Issue Jun 21, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@luismreis

luismreis commented Jun 21, 2014

Seems like $base-line-height defined at https://github.com/sapo/Ink/blob/master/src/sass/config/_typography.scss#L13 uses !default for the oposite that the comment line above states, ie, I'm getting it defined as 24px wich seems to be the compass default instead of the 1.45 defined on that line.

When "recompiling" the sass sources this is cause a error later on mixins/_typography.scss:

Line 31 of .tmp/styles/ink/mixins/_typography.scss: 7.85455em*px isn't a valid CSS value.

My error may be caused by any other thing, but the comment "Override default set in Compass' Vertical Rhythm partial." seems to be the oposite of what's described in sass docs.

@gnpfonseca

This comment has been minimized.

Show comment
Hide comment
@gnpfonseca

gnpfonseca Jun 23, 2014

Collaborator

You're right. That comment isn't exactly accurate.
We had some problems with compass default vertical rhythm mixins and we're not even using them. The value of $base-line-height is a proportion, so it should be stripped of any units.

We will adjust those comments for the next minor. And thx for the heads up.

Collaborator

gnpfonseca commented Jun 23, 2014

You're right. That comment isn't exactly accurate.
We had some problems with compass default vertical rhythm mixins and we're not even using them. The value of $base-line-height is a proportion, so it should be stripped of any units.

We will adjust those comments for the next minor. And thx for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment