New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Mistake with the "xlarge" Gutters #381

Closed
ninty9notout opened this Issue Jul 20, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@ninty9notout

ninty9notout commented Jul 20, 2014

I was running through the CSS for the gutters code in the xlarge media queries section and saw some margins that seemed a bit weird.

  .column-group.xlarge-gutters {
    margin-left: -2em;
  }
  .column-group.xlarge-gutters > [class*=xlarge-], .column-group.xlarge-gutters > [class*=all-], .column-group.xlarge-gutters > .all-auto {
    padding-left: 0.5em;
    margin-bottom: 0.5em;
  }

Specifically the 0.5em margins. Shouldn't they both be 2em?

@gnpfonseca

This comment has been minimized.

Show comment
Hide comment
@gnpfonseca

gnpfonseca Jul 21, 2014

Collaborator

We'll look into it. Thx for reporting.

Collaborator

gnpfonseca commented Jul 21, 2014

We'll look into it. Thx for reporting.

@gnpfonseca

This comment has been minimized.

Show comment
Hide comment
@gnpfonseca

gnpfonseca Jul 21, 2014

Collaborator

Could you please check which version are you using. I've just checked the latest and it was all good.

.column-group.xlarge-gutters {
    margin-left: -2em;
}
  .column-group.xlarge-gutters > [class*=xlarge-], .column-group.xlarge-gutters > [class*=all-] {
    padding-left: 2em;
    margin-bottom: 2em;
}
Collaborator

gnpfonseca commented Jul 21, 2014

Could you please check which version are you using. I've just checked the latest and it was all good.

.column-group.xlarge-gutters {
    margin-left: -2em;
}
  .column-group.xlarge-gutters > [class*=xlarge-], .column-group.xlarge-gutters > [class*=all-] {
    padding-left: 2em;
    margin-bottom: 2em;
}

@gnpfonseca gnpfonseca added the SASS/CSS label Jul 21, 2014

@ninty9notout

This comment has been minimized.

Show comment
Hide comment
@ninty9notout

ninty9notout Jul 21, 2014

According to the read me file, I have version 3.0.4 - I downloaded it off Github on 19/07. Not sure if this looks correct either:

  .xlarge-double-space {
    margin: 1em;
  }
  .xlarge-double-padding {
    padding: 1em;
  }
  .xlarge-half-space {
    margin: 4em;
  }
  .xlarge-half-padding {
    padding: 4em;
  }

ninty9notout commented Jul 21, 2014

According to the read me file, I have version 3.0.4 - I downloaded it off Github on 19/07. Not sure if this looks correct either:

  .xlarge-double-space {
    margin: 1em;
  }
  .xlarge-double-padding {
    padding: 1em;
  }
  .xlarge-half-space {
    margin: 4em;
  }
  .xlarge-half-padding {
    padding: 4em;
  }
@gnpfonseca

This comment has been minimized.

Show comment
Hide comment
@gnpfonseca

gnpfonseca Jul 21, 2014

Collaborator

Alright, spotted the problem. And is has already been fixed in dev. So it's just a matter of waiting for the next minor, which should be released in the next couple of days.

thx m8

Collaborator

gnpfonseca commented Jul 21, 2014

Alright, spotted the problem. And is has already been fixed in dev. So it's just a matter of waiting for the next minor, which should be released in the next couple of days.

thx m8

@ninty9notout

This comment has been minimized.

Show comment
Hide comment
@ninty9notout

ninty9notout Jul 22, 2014

No problem! Good framework you have here.

ninty9notout commented Jul 22, 2014

No problem! Good framework you have here.

@gnpfonseca

This comment has been minimized.

Show comment
Hide comment
@gnpfonseca

gnpfonseca Jul 23, 2014

Collaborator

Thx man. we do try :)

Collaborator

gnpfonseca commented Jul 23, 2014

Thx man. we do try :)

@gnpfonseca gnpfonseca closed this Jul 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment