feat: omit the warn log message about getting slash commands for all guilds #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawa-ko
changed the title
sawa-ko
changed the title
vladfrangu
requested changes
Jul 10, 2022
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
vladfrangu
requested changes
Jul 10, 2022
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
favna
approved these changes
Jul 18, 2022
vladfrangu
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if we have a bot with 5K servers and 30% of them invited the bot when it didn't have slash commands yet, the console will be filled with Spam about the warning message of not being able to get the guild commands.
By having it as an array type, it is impossible to avoid that, and this way you can make it work globally without having to put each guild id in the option.