Add detail page for artifacts and job. #6

Merged
merged 7 commits into from Dec 8, 2012

Conversation

Projects
None yet
3 participants
@splattael
Contributor

splattael commented Dec 5, 2012

Warning: Untested code ahead

I've just added detail pages for builds and jobs.

Repo

Each build displayed on the repo page is now linked to the specific build (e.g. #13 is linked).

Repo

Build details

The new build page display all jobs for this build. Each job links to the specific job detail page.

Builds

Job details

Display job details including job build log.

Job

Finally

The code in this PR is not tested and needs your feedback.

If you like the idea of this PR I'm happy to add specs and such.

@splattael

This comment has been minimized.

Show comment Hide comment
@splattael

splattael Dec 5, 2012

Contributor

This PR is related #3

Contributor

splattael commented Dec 5, 2012

This PR is related #3

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Dec 5, 2012

Owner

Awesome, I'll merge this in locally and add some tests to it before I push it.

Owner

sarahhodne commented Dec 5, 2012

Awesome, I'll merge this in locally and add some tests to it before I push it.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Dec 5, 2012

Owner

Just read the last line of your pull request. If you want to add specs, please do. I'll look over the code once more and give you some feedback.

Owner

sarahhodne commented Dec 5, 2012

Just read the last line of your pull request. If you want to add specs, please do. I'll look over the code once more and give you some feedback.

@sarahhodne

View changes

lib/travis/lite/templates/job.mustache
+ <li>Status: <span class="label label-{{status_class}}">{{status}}</li>
+ <li>Branch: {{branch}}</li>
+ <li>Language: {{config_label}}</li>
+ <li>Compare <a href="{{compare_url}}">on github</a></li>

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Dec 5, 2012

Owner

This should be "GitHub" and not "github". See @kneath's tweet.

@sarahhodne

sarahhodne Dec 5, 2012

Owner

This should be "GitHub" and not "github". See @kneath's tweet.

This comment has been minimized.

Show comment Hide comment
@kneath

kneath Dec 6, 2012

😻

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Dec 5, 2012

Owner

Code looks good. There are some naming issues, but they're mostly in the code I created earlier, so I'll just update everything later to remain consistent.

Owner

sarahhodne commented Dec 5, 2012

Code looks good. There are some naming issues, but they're mostly in the code I created earlier, so I'll just update everything later to remain consistent.

@ghost ghost assigned sarahhodne Dec 6, 2012

@splattael

This comment has been minimized.

Show comment Hide comment
@splattael

splattael Dec 6, 2012

Contributor

@henrikhodne I've added some specs.

I've moved format_build_status and friends to Layout. Repos are now being marking yellow when running.

You talked about "naming issues". Which one? :) I guess I misnamed Matrix which is might be called Artifact instead.

Contributor

splattael commented Dec 6, 2012

@henrikhodne I've added some specs.

I've moved format_build_status and friends to Layout. Repos are now being marking yellow when running.

You talked about "naming issues". Which one? :) I guess I misnamed Matrix which is might be called Artifact instead.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Dec 8, 2012

Owner

@splattael The naming issues I was actually the API methods not having the "type" of resource being returned in the name, but I must've misread the code since I don't see it anymore.

Matrix should be Matrix in my opinion, Artifact is a completely different thing (currently the only artifacts are logs).

Thanks for the PR!

Owner

sarahhodne commented Dec 8, 2012

@splattael The naming issues I was actually the API methods not having the "type" of resource being returned in the name, but I must've misread the code since I don't see it anymore.

Matrix should be Matrix in my opinion, Artifact is a completely different thing (currently the only artifacts are logs).

Thanks for the PR!

sarahhodne added a commit that referenced this pull request Dec 8, 2012

Merge pull request #6 from splattael/job-details
Add detail page for artifacts and jobs

@sarahhodne sarahhodne merged commit 63bbdd8 into sarahhodne:master Dec 8, 2012

1 check passed

default The Travis build passed
Details
@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Dec 8, 2012

Owner

Just deployed this. Thanks again!

Owner

sarahhodne commented Dec 8, 2012

Just deployed this. Thanks again!

@sarahhodne sarahhodne referenced this pull request Dec 8, 2012

Closed

No build/job view #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment