Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes in date picker for DateRangePicker #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

IchinoseBinit
Copy link

The previous code snippet did not allow selecting an initial date past the end date. Also, there was an issue with the null check where the method was called after setting the value to null with the argument passed with a null check.

I have resolved those issues for DateTimeRangePicker.

@sarbagyastha
Copy link
Owner

Hi @IchinoseBinit, thanks for the PR. Can you mention your use case, why do you want initial date past end date?

@sarbagyastha
Copy link
Owner

sarbagyastha commented Nov 11, 2021

The second issue was a blunder.

Could you please make the onEndDateChanged, ValueChanged<NepaliDateTime?> and remove all the bang operators from end dates that's being passed to the callback instead.

@IchinoseBinit
Copy link
Author

The first case has a use case like when a user tries to change the selected date after a certain start and end date has been selected by mistake or the users wishes to change the start and end date. It is useful as the first selection of the user might not always be a correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants