feat: Support plugins with scoped names

[scottnonnenberg]

I was getting this error:

Error: Cannot find module 'eslint-plugin-@scottnonnenberg/thehelp'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at getPluginRule (node_modules/eslint-find-rules/src/lib/rule-finder.js:41:26)
    ...

[codecov-io]

Current coverage is 100%

Merging #104 into master will not change coverage

@@           master   #104   diff @@
====================================
  Files           9      9          
  Lines         199    206     +7   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits          199    206     +7   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last updated by 851d6e3...878a7f1

[sarbbottam]

Should something/two-rule to be @someone/something/two-rule?

[ta2edchimp]

As I understand the ESLint docs, the rules are to be referenced by their containing plugin's name (regardless of their possibly scoped package's name).

So for eslint-plugin-<plugin-name>'s rules, as well as @scope/eslint-plugin-<plugin-name>, its rules should be configured via <plugin-name>/<rule-name>.

Please correct me, if I'm wrong.

[sarbbottam]

May not be a practical use case, curious to know, how does eslint handle, two or more scoped plugins, of the same name?

[scottnonnenberg]

@ta2edchimp I tested it in another project as I was working on this, and yes, for configuration rules take only the plugin name and not the scope name. Wasn't my first guess.

[sarbbottam]

@scottnonnenberg Thanks for the PR!

[scottnonnenberg]

That should take care of all the feedback - let me know if you've got anything else!

[sarbbottam]

👍 looks great! Thanks!

@ta2edchimp please have a look and merge if you don't have any comments.

[sarbbottam]

Ohh, @scottnonnenberg please add yourself to the contributors list

[ta2edchimp]

Really cool, thanks for the PR!