Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule-finder): Support scoped packages with dashes #305

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@chrisblossom
Copy link

commented Jul 2, 2019

Use eslint's internal functions to support shorthand eslint plugin naming.

fix #303

Show resolved Hide resolved src/lib/eslint-naming.js Outdated
Show resolved Hide resolved src/lib/eslint-naming.js Outdated
Show resolved Hide resolved src/lib/eslint-naming.js Outdated

@chrisblossom chrisblossom force-pushed the chrisblossom:fix-scope-with-dash branch 2 times, most recently from 8312b20 to 2c12490 Jul 2, 2019

Show resolved Hide resolved src/lib/rule-finder.js Outdated

@chrisblossom chrisblossom force-pushed the chrisblossom:fix-scope-with-dash branch from 2c12490 to 04c7f9f Jul 2, 2019

@chrisblossom chrisblossom force-pushed the chrisblossom:fix-scope-with-dash branch from 04c7f9f to 0512480 Jul 2, 2019

@chrisblossom

This comment has been minimized.

Copy link
Author

commented Jul 9, 2019

Are there any other requested changes to get this PR moving along?

@ljharb

ljharb approved these changes Jul 9, 2019

Copy link
Collaborator

left a comment

Thanks, i like the improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.