Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Detailed abuse reports switched to inbox (comment) style

  • Loading branch information...
commit bf0447963768f9d29e74549162e3e5e326579bcc 1 parent be626eb
sarken authored July 15, 2012
10  app/views/abuse_reports/index.html.erb
... ...
@@ -1,5 +1,6 @@
  1
+<div class="admin">
1 2
 <!--Descriptive page names, messages and instructions-->
2  
-<h2 class="heading"><%=ts("All Abuse Reports") %>:</h2>
  3
+<h2 class="heading"><%=ts("All Abuse Reports") %></h2>
3 4
 <!--/descriptions-->
4 5
 
5 6
 <!--subnav-->
@@ -7,8 +8,8 @@
7 8
 
8 9
 <!--main content-->
9 10
 <div class="wrapper">
10  
-<table id="abuse_reports_table" summary="<%= ts("The ID, sender, date, and reported URL for abuse reports made on the archive, as well as links to view the detailed report.") %>">
11  
-<caption><%=ts("All Abuse Reports Made on the Archive") %></caption>
  11
+<table id="abuse_reports_table" summary="<%= ts("Overview of all abuse reports, as well as links to view each detailed report.") %>">
  12
+<caption><%=ts("All Abuse Reports") %></caption>
12 13
 <colgroup>
13 14
 <col class="name" />
14 15
 <col />
@@ -34,4 +35,5 @@
34 35
 <!--/content-->
35 36
 <!--subnav-->
36 37
 	  <%= will_paginate @abuse_reports %>
37  
-<!--/subnav-->
  38
+<!--/subnav-->
  39
+</div>
32  app/views/abuse_reports/show.html.erb
... ...
@@ -1,40 +1,24 @@
  1
+<div class="admin">
1 2
 <!--Descriptive page name, messages and instructions--><h2 class="heading"><%= ts("Abuse Report") %> <%= @abuse_report.id %></h2>
2 3
 <!--/descriptions-->
3 4
 
4 5
 <!--subnav-->
5 6
 <ul class="navigation actions" role="navigation">
6  
-	<li><%= link_to ts("All abuse reports"), abuse_reports_path %></li>
  7
+	<li><%= link_to ts("All Abuse Reports"), abuse_reports_path %></li>
7 8
 </ul>
8 9
 <!--/subnav-->
9 10
 
10 11
 <!--main content-->
11  
-<!--FRONT END, should this be a table or should it be an inbox?
12  
-need to see some realdata to know, suspect inbox-->
13  
-<div class="wrapper">
14  
-	<table id="abuse_report_table" summary="<%= ts("The full abuse report including sender, URL of reported page, date reported, and detailed statement.") %>">
15  
-		<caption><%=ts("Detailed Abuse Report") %></caption>
16  
-		<tr>
17  
-			<th scope="row"><%=ts("From") %></th>
18  
-			<td><%= @abuse_report.email.blank? ? ts("Anonymous") : mail_to(@abuse_report.email) %></td>
19  
-		</tr>
20  
-		<tr>
21  
-			<th scope="row"><%=ts("Regarding") %></th>
22  
-			<td><%= link_to @abuse_report.url, @abuse_report.url %></td>
23  
-		</tr>
24  
-		<tr>
25  
-			<th scope="row"><%=ts("Reported") %></th>
26  
-			<td><%= time_ago_in_words @abuse_report.created_at %></td>
27  
-		</tr>
28  
-		<tr>
29  
-			<th scope="row"><%=ts("Statement") %></th>
30  
-			<td class="userstuff"><%=raw sanitize_field(@abuse_report, :comment) %></td>
31  
-		</tr>
32  
-	</table>
  12
+<div class="abuse comment group" role="article">
  13
+  <h4 class="heading byline"><%= @abuse_report.email.blank? ? ts("Anonymous") : mail_to(@abuse_report.email) %> <%= ts("regarding") %> <%= link_to @abuse_report.url, @abuse_report.url %></h4>
  14
+  <blockquote class="userstuff"><%=raw sanitize_field(@abuse_report, :comment) %></blockquote>
  15
+  <p class="datetime"><%= ts("Reported") %> <%= time_ago_in_words @abuse_report.created_at %></p>
33 16
 </div>
34 17
 <!--/content-->
35 18
 
36 19
 <!--subnav-->
37 20
 <ul class="navigation actions" role="navigation">
38  
-	<li><%= link_to ts("All abuse reports"), abuse_reports_path %></li>
  21
+	<li><%= link_to ts("All Abuse Reports"), abuse_reports_path %></li>
39 22
 </ul>
40 23
 <!--/subnav-->
  24
+</div>
12  public/stylesheets/site/2.0/24-role-admin.css
@@ -35,6 +35,18 @@ div.admin + h3.landmark {
35 35
   border-bottom: 3px solid #066;
36 36
 }
37 37
 
  38
+.admin .abuse.comment {
  39
+  clear: both;
  40
+}
  41
+
  42
+.admin .abuse.comment h4.byline {
  43
+  padding-left: 0.25em;
  44
+}
  45
+
  46
+.admin .abuse.comment .userstuff {
  47
+  margin: 0.643em;
  48
+}
  49
+
38 50
 /* TABLES AND LISTS */
39 51
 
40 52
 table, thead td {

0 notes on commit bf04479

sarken

A table wasn't right, but we don't have a design pattern known as inbox. Instead, we have comments, which are used inside the inbox.

sarken

Removes overlap with navigation

sarken

This and the below override the comment-related styling that leaves space for user icons, since abuse reports don't get icons

Please sign in to comment.
Something went wrong with that request. Please try again.