Permalink
Browse files

Detailed abuse reports switched to inbox (comment) style

  • Loading branch information...
1 parent be626eb commit bf0447963768f9d29e74549162e3e5e326579bcc @sarken committed Jul 15, 2012
@@ -1,14 +1,15 @@
+<div class="admin">
<!--Descriptive page names, messages and instructions-->
-<h2 class="heading"><%=ts("All Abuse Reports") %>:</h2>
+<h2 class="heading"><%=ts("All Abuse Reports") %></h2>
<!--/descriptions-->
<!--subnav-->
<!--/subnav-->
<!--main content-->
<div class="wrapper">
-<table id="abuse_reports_table" summary="<%= ts("The ID, sender, date, and reported URL for abuse reports made on the archive, as well as links to view the detailed report.") %>">
-<caption><%=ts("All Abuse Reports Made on the Archive") %></caption>
+<table id="abuse_reports_table" summary="<%= ts("Overview of all abuse reports, as well as links to view each detailed report.") %>">
+<caption><%=ts("All Abuse Reports") %></caption>
<colgroup>
<col class="name" />
<col />
@@ -34,4 +35,5 @@
<!--/content-->
<!--subnav-->
<%= will_paginate @abuse_reports %>
-<!--/subnav-->
+<!--/subnav-->
+</div>
@@ -1,40 +1,24 @@
+<div class="admin">
@sarken

sarken Jul 15, 2012

Owner

Allows targeting

<!--Descriptive page name, messages and instructions--><h2 class="heading"><%= ts("Abuse Report") %> <%= @abuse_report.id %></h2>
<!--/descriptions-->
<!--subnav-->
<ul class="navigation actions" role="navigation">
- <li><%= link_to ts("All abuse reports"), abuse_reports_path %></li>
+ <li><%= link_to ts("All Abuse Reports"), abuse_reports_path %></li>
</ul>
<!--/subnav-->
<!--main content-->
-<!--FRONT END, should this be a table or should it be an inbox?
@sarken

sarken Jul 15, 2012

Owner

A table wasn't right, but we don't have a design pattern known as inbox. Instead, we have comments, which are used inside the inbox.

-need to see some realdata to know, suspect inbox-->
-<div class="wrapper">
- <table id="abuse_report_table" summary="<%= ts("The full abuse report including sender, URL of reported page, date reported, and detailed statement.") %>">
- <caption><%=ts("Detailed Abuse Report") %></caption>
- <tr>
- <th scope="row"><%=ts("From") %></th>
- <td><%= @abuse_report.email.blank? ? ts("Anonymous") : mail_to(@abuse_report.email) %></td>
- </tr>
- <tr>
- <th scope="row"><%=ts("Regarding") %></th>
- <td><%= link_to @abuse_report.url, @abuse_report.url %></td>
- </tr>
- <tr>
- <th scope="row"><%=ts("Reported") %></th>
- <td><%= time_ago_in_words @abuse_report.created_at %></td>
- </tr>
- <tr>
- <th scope="row"><%=ts("Statement") %></th>
- <td class="userstuff"><%=raw sanitize_field(@abuse_report, :comment) %></td>
- </tr>
- </table>
+<div class="abuse comment group" role="article">
+ <h4 class="heading byline"><%= @abuse_report.email.blank? ? ts("Anonymous") : mail_to(@abuse_report.email) %> <%= ts("regarding") %> <%= link_to @abuse_report.url, @abuse_report.url %></h4>
+ <blockquote class="userstuff"><%=raw sanitize_field(@abuse_report, :comment) %></blockquote>
+ <p class="datetime"><%= ts("Reported") %> <%= time_ago_in_words @abuse_report.created_at %></p>
</div>
<!--/content-->
<!--subnav-->
<ul class="navigation actions" role="navigation">
- <li><%= link_to ts("All abuse reports"), abuse_reports_path %></li>
+ <li><%= link_to ts("All Abuse Reports"), abuse_reports_path %></li>
</ul>
<!--/subnav-->
+</div>
@@ -35,6 +35,18 @@ div.admin + h3.landmark {
border-bottom: 3px solid #066;
}
+.admin .abuse.comment {
@sarken

sarken Jul 15, 2012

Owner

Removes overlap with navigation

+ clear: both;
+}
+
+.admin .abuse.comment h4.byline {
@sarken

sarken Jul 15, 2012

Owner

This and the below override the comment-related styling that leaves space for user icons, since abuse reports don't get icons

+ padding-left: 0.25em;
+}
+
+.admin .abuse.comment .userstuff {
+ margin: 0.643em;
+}
+
/* TABLES AND LISTS */
table, thead td {

0 comments on commit bf04479

Please sign in to comment.