Minicpan integration #4

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

hoelzro commented Aug 4, 2011

Hello,

I added minicpan integration, which works for all but about 12,000 modules on the CPAN. Most of the problematic modules are found under the examples/ or eg/ directories in their distributions, so I figured this was an acceptable compromise.

Thanks,
Rob

Owner

sartak commented Aug 6, 2011

You rock! But oh god is there a lot of new code. :) I'm wondering if a separate dist would be better for this. Most especially so you don't have to wait on me to actually review, merge, and release your code, but also because it's kinda nice that cpandoc currently has no dependencies on 5.14.

hoelzro commented Aug 6, 2011

Yeah, I know...a little much. Unfortunately, it's all necessary to get the job done (as far as I can tell). What part of my code depends on 5.14?

As far as another dist goes, any suggestion for a name? minicpandoc seems a little wordy =)

Owner

sartak commented Aug 9, 2011

Nothing depends on 5.14, just saying that if you're running on 5.14 then cpandoc itself has no dependencies. That's just a tiny victory though, I'm not too concerned about dependencies.

I'm not sure what the right way forward for this is. :/

hoelzro commented Aug 9, 2011

Ah, gotcha. I realize I wasn't very conservative with my usage of modules, but I think that all of the additions are necessary (except for maybe File::Spec).

It's your call; I personally think this would be a nice addition (I was just using my modified version to look at module docs on a plane), but I understand if you're hesitant to add dependencies and some code bloat.

Owner

sartak commented Aug 9, 2011

File::Spec has been in core for a long time now, so no worries there.

I'll think about it. I do want the feature, but it is a lot of new code.

Owner

sartak commented Aug 9, 2011

File::Spec has been in core for a long time now, so no worries there.

I do want the feature, but it is a lot of new code where the metacpan version is pretty simple. I'll think about it!

hoelzro commented Sep 9, 2011

@sartak Any thoughts on this in the past month?

hoelzro commented Oct 8, 2011

Just thought I'd ping you on this topic once again! I understand if you're nervous about bringing the changes and dependencies into Pod::Cpandoc; that being the case, would you mind if I forked this to create Pod::Minicpandoc? I'd like the functionality, but I'd rather not have to manage my own custom Pod::Cpandoc. Also, you could still merge the code at a later date if you wanted to!

Thanks,
Rob

Owner

sartak commented Aug 7, 2012

Just noticed this issue again. I think a Pod::Minicpandoc is the way to go. :)

sartak closed this Aug 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment