Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lockfile #9

Merged
merged 5 commits into from Jun 16, 2018
Merged

Fix lockfile #9

merged 5 commits into from Jun 16, 2018

Conversation

@orsinium
Copy link
Contributor

@orsinium orsinium commented Jun 16, 2018

Thank you for pipenv and this useful lib for working with Pipfile.

I'm found some troubles while I'm work this Lockfile and fix it:

  • Incorrect example for Lockfile into readme.
  • Incorrect default values for Lockfile
@techalchemy
Copy link
Member

@techalchemy techalchemy commented Jun 16, 2018

Hey, thanks for the changes! I snuck this in super quickly to get it into pipenv for testing, and was planning to broadcast its existence soon to see if there is anything broken about it (besides the stuff we've already been fixing).

The PR looks pretty spot on, thanks for the contribution!

@techalchemy techalchemy merged commit 249764e into sarugaku:master Jun 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
techalchemy added a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants