Unicode handling #138
Merged
Unicode handling #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.encode()` and `.decode()` calls were added because of various objects gaining a `__repr__()` implementation. `__repr__()` needs to return `str` on Python 2 (byte string) and `str` on Python 3 (unicode string). This commit keeps everything in unicode strings internally, improving behavior on Python 3. Unfortunately, this also breaks existing Python 3 code relying on various attributes being bytes. Also introduce a `compat` module to easily return `str` from any string in Python 2 and 3.
This allows running 'tox' and get all tests run for various Python versions, in isolated virtual environments.
|
Note that Python 3 code relying on the current behavior (board name being bytes for example) will break. But it's for a greater good :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
Fixes #135
Following #135, here's my proposal for keeping unicode data internally and having safe
__repr__implementations. More details can be found in the commit message.Additional changes:
assertEqualswithassertEqual(avoids a warning on Python3)