From e2b93b5ac431b3229e86a84f7bad5ae96dbdd50e Mon Sep 17 00:00:00 2001 From: Bartosz Firyn Date: Thu, 10 Jan 2013 19:34:33 +0100 Subject: [PATCH] Remove unnecessary synchronized code blocks [ci skip] --- .../java/com/github/sarxos/webcam/Webcam.java | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/webcam-capture/src/main/java/com/github/sarxos/webcam/Webcam.java b/webcam-capture/src/main/java/com/github/sarxos/webcam/Webcam.java index 96c40bf4..72abec5c 100644 --- a/webcam-capture/src/main/java/com/github/sarxos/webcam/Webcam.java +++ b/webcam-capture/src/main/java/com/github/sarxos/webcam/Webcam.java @@ -439,18 +439,14 @@ public boolean addWebcamListener(WebcamListener l) { if (l == null) { throw new IllegalArgumentException("Webcam listener cannot be null!"); } - synchronized (listeners) { - return listeners.add(l); - } + return listeners.add(l); } /** * @return All webcam listeners */ public WebcamListener[] getWebcamListeners() { - synchronized (listeners) { - return listeners.toArray(new WebcamListener[listeners.size()]); - } + return listeners.toArray(new WebcamListener[listeners.size()]); } /** @@ -460,9 +456,7 @@ public WebcamListener[] getWebcamListeners() { * @return True if listener has been removed, false otherwise */ public boolean removeWebcamListener(WebcamListener l) { - synchronized (listeners) { - return listeners.remove(l); - } + return listeners.remove(l); } /** @@ -649,6 +643,9 @@ public static boolean isHandleTermSignal() { * @return True, if listeners list size has been changed, false otherwise */ public static boolean addDiscoveryListener(WebcamDiscoveryListener l) { + if (l == null) { + throw new IllegalArgumentException("Webcam discovery listener cannot be null!"); + } return DISCOVERY_LISTENERS.add(l); }