New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#653 Fix dependency conflict issue for com.nativelibs4java:bridj:jar #655

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@LeoAugust19
Contributor

LeoAugust19 commented Aug 12, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 12, 2018

Coverage Status

Coverage decreased (-0.05%) to 18.78% when pulling 847fb9e on LeoAugust19:work into a837030 on sarxos:master.

coveralls commented Aug 12, 2018

Coverage Status

Coverage decreased (-0.05%) to 18.78% when pulling 847fb9e on LeoAugust19:work into a837030 on sarxos:master.

@LeoAugust19

This comment has been minimized.

Show comment
Hide comment
@LeoAugust19

LeoAugust19 Aug 12, 2018

Contributor

@yuripourre hi, could you please help review this PR?

Thanks a lot.

Regards,
Leo

Contributor

LeoAugust19 commented Aug 12, 2018

@yuripourre hi, could you please help review this PR?

Thanks a lot.

Regards,
Leo

@yuripourre

This comment has been minimized.

Show comment
Hide comment
@yuripourre

yuripourre Aug 15, 2018

Contributor

I just saw your mention, sorry.

I can certainly review it but @sarxos is the owner and who can merge it and take some action.

Contributor

yuripourre commented Aug 15, 2018

I just saw your mention, sorry.

I can certainly review it but @sarxos is the owner and who can merge it and take some action.

@yuripourre

This comment has been minimized.

Show comment
Hide comment
@yuripourre

yuripourre Aug 16, 2018

Contributor

Since webcam-capture/pom.xml was updated to use bridj 0.7.0, seems like driver-openimaj/pom.xml was forgotten.

The project still compiles, and tests are passing. I think it should be merged.

@sarxos Can you please take a look too?

Contributor

yuripourre commented Aug 16, 2018

Since webcam-capture/pom.xml was updated to use bridj 0.7.0, seems like driver-openimaj/pom.xml was forgotten.

The project still compiles, and tests are passing. I think it should be merged.

@sarxos Can you please take a look too?

@LeoAugust19

This comment has been minimized.

Show comment
Hide comment
@LeoAugust19

LeoAugust19 Aug 17, 2018

Contributor

@yuripourre @sarxos Thanks a lot. :- p

Contributor

LeoAugust19 commented Aug 17, 2018

@yuripourre @sarxos Thanks a lot. :- p

@sarxos

This comment has been minimized.

Show comment
Hide comment
@sarxos

sarxos Oct 5, 2018

Owner

Hi @yuripourre, @LeoAugust19, sorry for such late response. I was on a long vacation when this pull request appeared and I simply missed it. I'm merging this right now. Thank you!

Owner

sarxos commented Oct 5, 2018

Hi @yuripourre, @LeoAugust19, sorry for such late response. I was on a long vacation when this pull request appeared and I simply missed it. I'm merging this right now. Thank you!

@sarxos sarxos merged commit c3c3e22 into sarxos:master Oct 5, 2018

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 18.78%
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment