Fix for #59 - Add JSHint global declaration to generated components when necessary #63

Merged
merged 5 commits into from Mar 3, 2014

Conversation

Projects
None yet
2 participants
Collaborator

js1972 commented Feb 26, 2014

No description provided.

js1972 added some commits Feb 26, 2014

@js1972 js1972 refactor(tiles app): Refactor to use a local json data source and add…
… some fields on detail page.

There are numerous issues with both the real Northwind sampel OData service as well as the mock one provided in the UI5 SDK. Replace with local json sample data.
Enchance the detail page to show a couple of controls instead of an empty page.

Fixes #61
5d6e6c1
@js1972 js1972 test(tiles app): change expected files to reflect new sample json. 6d736ea
@js1972 js1972 fix(sub generators): Add jshint global declaration for namespace in n…
…ew components.

When a uiComponent or facelessComponent is generated a namespace is prefixed.
JSHint will compain about the top-level object name in the namespace being
 undefined so we add it as a global:
 e.g. foo.bar.myComponent => add /*global foo*/ to top of file.

Fixes #59
cd9b039

js1972 closed this Feb 26, 2014

js1972 reopened this Feb 26, 2014

@js1972 js1972 feat(gen:view): Scaffold views with correct UI5 library.
- When the view generator is run it will scaffold out a view that uses the same UI5 library
 as used in the projects index.html (sap.m or sap.ui.commons).

- The view generator now includes a function to determine which library type is used by your
 app: whichUI5Library().

- Minor refactor to the classic app template - the Application.js had spurious whitespace and
 the _index.html created a variable (app) that was never used.

Fixes #53
7e8f56d
Collaborator

js1972 commented Feb 26, 2014

Added another commit to this one which fixes bug #53.

@saschakiefer saschakiefer added a commit that referenced this pull request Mar 3, 2014

@saschakiefer saschakiefer Merge pull request #63 from js1972/globals
Fix for #59 - Add JSHint global declaration to generated components when necessary
7b16aaa

@saschakiefer saschakiefer merged commit 7b16aaa into saschakiefer:develop Mar 3, 2014

1 check passed

default The Travis CI build passed
Details

js1972 deleted the js1972:globals branch Jul 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment