fix: local login component should not pop up when login mechanism is … #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuryShkoda
approved these changes
Mar 31, 2022
Member
YuryShkoda
left a comment
YuryShkoda
left a comment
There was a problem hiding this comment.
Looks good, but it would be nice to have PR description.
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…redirected
When the user is not logged in then a login component pops up on the screen. But when login mechanism is redirected then login method of sasjs adapter should be called, that in result will show sas login modal.