Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridのClassの命名が微妙かも。 #7

Closed
torounit opened this issue Jan 19, 2016 · 1 comment
Closed

GridのClassの命名が微妙かも。 #7

torounit opened this issue Jan 19, 2016 · 1 comment

Comments

@torounit
Copy link
Contributor

_row, _col となっているが、基本的には、

_rowの直下の子要素に_colが来る

という使い方以外はしないはずなので、であれば、_row__col のようなElementとして命名すべきかと。

@inc2734
Copy link
Member

inc2734 commented Jan 20, 2016

頻繁に使うクラスだから長くしたくないなと思ってそうしていたのですが、確かにそこだけ統一されていないというのもおかしいですね。修正しようと思います。

inc2734 added a commit that referenced this issue Jan 20, 2016
@inc2734 inc2734 closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants