Permalink
Browse files

gh-pages now builds successfully

This addresses one half of #183. We needed to both (1) be able to
generate the gh-pages branch again and (2) be able to map eyeglass.rocks
to the new `A` record from github. When attempting a rebuild with node
v8 and v10, the following problems were discovered:

* `gulp-gh-pages` uses an outdated version of `gift`
* `eyeglass-dev-site-builder` needs updated `eyeglass` & `node-sass`

This was fixed by changing the dependency on `gulp-gh-pages` to the
community module `gulp-gh-pages-will`. To fix the eyeglass dependency,
the values in `package-lock.json` were manually increased to a version
of `eyeglass` and `node-sass` that do not run into an Abort Trap on OSX.
  • Loading branch information...
Jakobo committed Nov 2, 2018
1 parent f26ea16 commit d802f4f2b6418a899f5d9d376c8c69beb73bd8c1
Showing with 1,312 additions and 1,994 deletions.
  1. +1 −0 .node-version
  2. +4 −1 build/site.js
  3. +1,306 −1,992 package-lock.json
  4. +1 −1 package.json
@@ -0,0 +1 @@
8.11.3
@@ -1,7 +1,10 @@
"use strict";
var SiteBuilder = require("eyeglass-dev-site-builder");
var ghPages = require("gulp-gh-pages");
// broken gift dependency in gulp-gh-pages. Using community adopted fork
// https://github.com/shinnn/gulp-gh-pages/pull/117
var ghPages = require("gulp-gh-pages-will");
var merge = require("lodash.merge");
var fs = require("fs-extra");
Oops, something went wrong.

0 comments on commit d802f4f

Please sign in to comment.