Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support source maps #2

Closed
nex3 opened this Issue Oct 31, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@nex3
Copy link
Contributor

nex3 commented Oct 31, 2016

We need to support source maps, as close to Ruby Sass and LibSass as possible. Hopefully this shouldn't be too difficult, since we're already tracking source spans everywhere.

  • Add support to the Dart API.
  • Add support to the JS API.
  • Add support to the CLI.
  • Track variable definitions.
@gabrielmaldi

This comment has been minimized.

Copy link

gabrielmaldi commented Aug 9, 2017

Hey, sorry to bother, but is this on the roadmap anytime soon? It's the only thing preventing us from migrating to the awesome dart-sass 😄 Thanks!

@nex3

This comment has been minimized.

Copy link
Contributor Author

nex3 commented Aug 9, 2017

This is scheduled for after the 1.0.0 stable release. Our first priority is getting the language implementation compatible, which is largely in place, and getting the JavaScript API node-sass compatible, which is not. Once 1.0.0 is out, though, this will be a high-priority feature.

If you're interested in getting this sooner, contributions would be rad! A lot of the infrastructure is already in place: we store source spans for the full CSS AST, so all you'd need to do is pipe those to the source_maps package.

@nex3 nex3 added this to the Usability Equivalence milestone Mar 23, 2018

nex3 added a commit that referenced this issue Apr 19, 2018

nex3 added a commit that referenced this issue Apr 19, 2018

nex3 added a commit that referenced this issue Apr 21, 2018

nex3 added a commit that referenced this issue Apr 21, 2018

nex3 added a commit that referenced this issue Apr 25, 2018

Add CLI source map support
Partially addresses #2

nex3 added a commit that referenced this issue Apr 25, 2018

Add CLI source map support
Partially addresses #2

nex3 added a commit that referenced this issue Apr 25, 2018

Add CLI source map support (#309)
Partially addresses #2

nex3 added a commit that referenced this issue Apr 26, 2018

nex3 added a commit that referenced this issue Apr 26, 2018

nex3 added a commit that referenced this issue Apr 26, 2018

nex3 added a commit that referenced this issue Apr 26, 2018

@nex3 nex3 closed this in #310 Apr 26, 2018

@gabrielmaldi

This comment has been minimized.

Copy link

gabrielmaldi commented Apr 26, 2018

Great to see this implemented, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.