New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing !important in custom property value causes error #260

Closed
xzyfer opened this Issue Mar 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@xzyfer

xzyfer commented Mar 17, 2018

Originally reported in sass/libsass#2590

According to the spec, this is allowed

Note: Custom properties can contain a trailing !important, but this is automatically removed from the property’s value by the CSS parser, and makes the custom property "important" in the CSS cascade. In other words, the prohibition on top-level "!" characters does not prevent !important from being used, as the !important is removed before syntax checking happens.

@nex3

This comment has been minimized.

Contributor

nex3 commented Mar 22, 2018

Yeah, we should allow this.

@nex3 nex3 added the bug label Mar 22, 2018

nex3 added a commit to sass/sass-spec that referenced this issue Mar 22, 2018

nex3 added a commit that referenced this issue Mar 22, 2018

nex3 added a commit to sass/sass that referenced this issue Mar 22, 2018

nex3 added a commit to sass/sass that referenced this issue Mar 22, 2018

nex3 added a commit to sass/sass that referenced this issue Mar 23, 2018

nex3 added a commit to sass/sass-spec that referenced this issue Mar 23, 2018

@nex3 nex3 closed this in 4c293f3 Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment