Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.23.0-module.beta.1 was mistakenly released under the `latest` dist-tag #818

Closed
sodatea opened this issue Sep 5, 2019 · 18 comments

Comments

@sodatea
Copy link

commented Sep 5, 2019

ζ npm view sass@latest version
1.23.0-module.beta.1

If users install dart sass via npm install sass and use it along with sass-loader, sass-loader's version check will fail.
https://github.com/webpack-contrib/sass-loader/blob/aa9b53b4d1c14117c4ca114a13cecb6e53b4e87a/src/getSassImplementation.js#L28-L31

@nex3 nex3 added the infrastructure label Sep 5, 2019

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

I want to fix this, but npm dist-tag is giving me bogus 401 error codes. I've reached out to npm support about it.

As an aside, it's baffling to me that this is the default behavior for publishing a pre-release version of a package.

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 8, 2019

@nex3 any update regarding this?

@sodatea sodatea changed the title 1.23.0-module.beta.1 wass mistakenly released under the `latest` dist-tag 1.23.0-module.beta.1 was mistakenly released under the `latest` dist-tag Sep 8, 2019

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

I haven't heard back from npm support about the npm dist-tag issue.

@vladimiry

This comment has been minimized.

Copy link

commented Sep 11, 2019

The half-measure: npm deprecate sass@v1.23.0-module.beta.1 "incorrect publishing channel"

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Well, I don't want it to be deprecated; it's definitely a valid person I want people to be able to use. I think this will be solved when we release the next stable version, which should be soon.

@vladimiry

This comment has been minimized.

Copy link

commented Sep 11, 2019

Deprecation doesn't prevent someone to use the version but it would be a clear indication that there is something wrong with the publication.

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 11, 2019

Well, I don't want it to be deprecated; it's definitely a valid person I want people to be able to use. I think this will be solved when we release the next stable version, which should be soon.

you should deprecate this version
release it again with a new versionand the correct tag (beta)

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Why would deprecating it be better than releasing a new stable version that will take the latest tag?

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 11, 2019

the time
if you will release a new stable version now then it would be perfect
but till you do so a lot of people would use a beta version as it's stable

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

It's no faster to release a new version of the beta than it is to release a new version of the stable release.

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 11, 2019

It's no faster to release a new version of the beta than it is to release a new version of the stable release.

i meant to release the old version again
i mean checkout the commit that was released and just build run the npm publish command

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

I'm pretty sure npm forbids re-releasing a version that's already been uploaded.

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 11, 2019

I'm pretty sure npm forbids re-releasing a version that's already been uploaded.

i missed to say change the npm version

so here is what i meant
checkout the commit that was released and just bump the version number, build and run the npm publish command

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Once we have to bump the package version, it's not trivial to release a new version.

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 11, 2019

Once we have to bump the package version, it's not trivial to release a new version.

if you can explain why maybe someone can help

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

You'll either have to look at our deployment infrastructure, or just take my word for it.

Anyway, we're in the process of releasing a new stable version right now, so this is a moot point.

@robertIsaac

This comment has been minimized.

Copy link

commented Sep 11, 2019

You'll either have to look at our deployment infrastructure, or just take my word for it.

Anyway, we're in the process of releasing a new stable version right now, so this is a moot point.

okay i will take your word

sorry for bothering you

@nex3

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

1.22.12 has been released, so I'm closing this out.

@nex3 nex3 closed this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.