Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`@import`-ing two modules with conflicting members should not error #888

Closed
jathak opened this issue Nov 20, 2019 · 0 comments
Assignees
Labels
bug

Comments

@jathak
Copy link
Member

@jathak jathak commented Nov 20, 2019

Currently, if two modules that expose members with the same name are loaded via @import (or even one module that's imported twice) and one of these members is referenced, Sass errors saying that the member is available from multiple global modules.

e.g.

// entrypoint.scss
@import "a";
@import "b";

a { color: $var }

// _a.scss
@forward "shared";

// _b.scss
@forward "shared";

// _shared.scss
$var: blue;

By the semantics for @import in the module system proposal, members from later @import rules should override previous definitions, even if they came from another @import.

@nex3 nex3 added the bug label Nov 20, 2019
@nex3 nex3 self-assigned this Nov 20, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Nov 21, 2019
@nex3 nex3 closed this in 731bd44 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.