Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LegacyResult.map to undefined rather than null #1592

Merged
merged 2 commits into from Jan 10, 2022
Merged

Set LegacyResult.map to undefined rather than null #1592

merged 2 commits into from Jan 10, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jan 8, 2022

@nex3 nex3 requested a review from jathak Jan 8, 2022
jathak
jathak approved these changes Jan 10, 2022
@@ -357,7 +357,7 @@ RenderResult _newRenderResult(
var end = DateTime.now();

var css = result.css;
Uint8List? sourceMapBytes;
Uint8List? sourceMapBytes = undefined;
Copy link
Member

@jathak jathak Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be dynamic to satisfy the type checker since undefined isn't null.

Copy link
Contributor Author

@nex3 nex3 Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, I guess pulyaevskiy/node-interop#109 hasn't been released yet.

@nex3 nex3 merged commit 720c358 into main Jan 10, 2022
36 checks passed
@nex3 nex3 deleted the legacy-result-map branch Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants