Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing files relative to "package:" imports #638

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@nex3
Copy link
Contributor

commented Apr 3, 2019

The PackageImporter wasn't accepting paths relative to its
canonicalized outputs as inputs.

Closes #631

Fix importing files relative to "package:" imports
The PackageImporter wasn't accepting paths relative to its
canonicalized outputs as inputs.

Closes #631

@nex3 nex3 requested a review from jathak Apr 3, 2019

@jathak

jathak approved these changes Apr 3, 2019

@nex3 nex3 merged commit 8c9412b into master Apr 3, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nex3 nex3 deleted the relative-package-imports branch Apr 3, 2019

@aaronlademann-wf

This comment has been minimized.

Copy link

commented Apr 3, 2019

Thank you @nex3 !!!!!!!!!

aaronlademann-wf added a commit to Workiva/w_common that referenced this pull request Apr 15, 2019

aaronlademann-wf added a commit to Workiva/w_common that referenced this pull request Apr 16, 2019

Bump sass version
+ Technically we need 1.18.0 to pull in sass/dart-sass#638, but that is Dart 2 only - and the highest possible Dart 1 version (1.6.0) seems to have a working implementation of `package:` imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.