Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only error for directly configured core modules #839

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@jathak
Copy link
Member

commented Oct 4, 2019

@jathak jathak requested a review from nex3 Oct 4, 2019
@nex3
nex3 approved these changes Oct 10, 2019
@nex3

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Can you add a changelog entry as well, and bump the pubspec version to 1.23.1-dev?

@jathak jathak force-pushed the configuration-builtin branch from b8e45a6 to b8e2dbc Oct 10, 2019
@jathak jathak merged commit c663995 into master Oct 10, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jathak jathak deleted the configuration-builtin branch Oct 10, 2019
@jathak

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

I just realized that I didn't actually git add the changelog entry and version bump when I amended this commit. Should I open a new PR for that or just commit it directly to master?

@nex3

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Looks like you figured it out in #113?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.