Support improvements to the new JS API #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
js-api-improvements
branch
3 times, most recently
from
768a60a
to
376ad1d
Compare
These are now tested in the sass-spec repo.
nex3
force-pushed
the
js-api-improvements
branch
from
376ad1d
to
3309b77
Compare
stof
reviewed
Nov 16, 2021
Awjin
suggested changes
Nov 18, 2021
nex3
force-pushed
the
js-api-improvements
branch
from
9c5b9d6
to
b80efe2
Compare
Awjin
approved these changes
Nov 19, 2021
This is necessary because Jest transitively depends on jsdom, which won't compile without DOM types ambiently available. See jestjs/jest#12098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3200
See sass/sass-spec#1741