Make the build reproducible #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septatrix
approved these changes
Mar 31, 2021
|
feel free to send a new PR which passes the tests -- otherwise looks fine |
Thanks for the review.Three things from that:
|
|
ah I assumed since it has sat since October with a failing status that you weren't working on it any more:
|
|
I will not merge with failing stauses, no |
|
Ah, didn't see "failing check" until now - this changes everything and will address shortly, likely tomorrow. :) |
lamby
force-pushed
the
971527-libsass-python-please-make-the-build-reproducible
branch
from
522b8e9
to
74889e5
Compare
|
Updated 👍 - thanks @asottile |
Whilst working on the Reproducible Builds effort [0] we noticed that libsass-python could not be built reproducibly. This is due to the manpage containing content that is generated by iterating over a Python frozenset type, which is non-deterministic. This was originally filed in Debian as #971527 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/971527
lamby
force-pushed
the
971527-libsass-python-please-make-the-build-reproducible
branch
from
7ac5903
to
905d3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort we noticed that libsass-python could not be built reproducibly. This is due to the manpage containing content that is generated by iterating over a Python
frozensettype, which is non-deterministic.This was originally filed in Debian as #971527.