Extended selectors wont compile correctly (with both regular and silent selectors) #146

Closed
lmartins opened this Issue Aug 9, 2013 · 112 comments

Comments

Projects
None yet
@lmartins

lmartins commented Aug 9, 2013

When you have something like:

%btn-style-default{
  background: green;
  &:hover{
    background: black;
  }
}

and extend this selector with:

button{
  @extend %btn-style-default;
}

should compile to:

button{
   background: green;
}
button:hover{
   backgroud: black
}

but instead it compiles to invalid (and obviously non-functional) css:

button {
  background: green; }
  %btn-style-default:hover {
    background: black; }

Any news on this?

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Aug 9, 2013

The only way I can get something similar is by using mixins, but that's far from ideal.

lmartins commented Aug 9, 2013

The only way I can get something similar is by using mixins, but that's far from ideal.

@hcatlin

This comment has been minimized.

Show comment
Hide comment
@hcatlin

hcatlin Aug 9, 2013

Member

Just added a spec test for this example...
sass/sass-spec@8a6a1c3

Member

hcatlin commented Aug 9, 2013

Just added a spec test for this example...
sass/sass-spec@8a6a1c3

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Aug 9, 2013

Referencing #80. This feature is difficult to implement completely, so I can't give an ETA yet.

akhleung commented Aug 9, 2013

Referencing #80. This feature is difficult to implement completely, so I can't give an ETA yet.

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Aug 9, 2013

@akhleung Sure, I get it. Thanks for all the hard work, wish I was able to help here.

lmartins commented Aug 9, 2013

@akhleung Sure, I get it. Thanks for all the hard work, wish I was able to help here.

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Aug 21, 2013

Just to add to this issue, i've noticed that even regular selectors wont extend correctly:

.f-row--defaults{

  margin-bottom: 1.5em;

  &:last-child{
    margin-bottom: 0;
    border: 1px solid red;
  }

}

and then extend any selector with:
@extend .f-row--defaults;

It will only inerhit the base rule margin-bottom but not the child selector also declared on the selector used as extender.

Just to add to this issue, i've noticed that even regular selectors wont extend correctly:

.f-row--defaults{

  margin-bottom: 1.5em;

  &:last-child{
    margin-bottom: 0;
    border: 1px solid red;
  }

}

and then extend any selector with:
@extend .f-row--defaults;

It will only inerhit the base rule margin-bottom but not the child selector also declared on the selector used as extender.

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Oct 10, 2013

Sorry to ping this, but is there any estimation on when will this be available?

Sorry to ping this, but is there any estimation on when will this be available?

@mshwery

This comment has been minimized.

Show comment
Hide comment
@mshwery

mshwery Oct 21, 2013

+1. Really really incredibly important to the usefulness of sass.

mshwery commented Oct 21, 2013

+1. Really really incredibly important to the usefulness of sass.

@emagnier

This comment has been minimized.

Show comment
Hide comment
@emagnier

emagnier Oct 21, 2013

+1. Same for me.

+1. Same for me.

@JohnONolan

This comment has been minimized.

Show comment
Hide comment
@JohnONolan

JohnONolan Oct 30, 2013

+1 this is a must-have

+1 this is a must-have

@ErisDS ErisDS referenced this issue in TryGhost/Ghost Oct 30, 2013

Closed

Remove dependency on Ruby #1346

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Oct 30, 2013

We know this is an important feature and we're bumping up the priority on it ... it is, however, a very difficult feature to get completely right, but I'm hoping to consult with @nex3 in the near future to figure out how he did it in Ruby Sass.

We know this is an important feature and we're bumping up the priority on it ... it is, however, a very difficult feature to get completely right, but I'm hoping to consult with @nex3 in the near future to figure out how he did it in Ruby Sass.

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Oct 30, 2013

You guys are doing an awesome job. Thank your for that and for tolerating our impatience.
I just can't use Ruby Sass now.

You guys are doing an awesome job. Thank your for that and for tolerating our impatience.
I just can't use Ruby Sass now.

@benfrain

This comment has been minimized.

Show comment
Hide comment
@benfrain

benfrain Oct 30, 2013

Just to echo everything Luis said :)

Just to echo everything Luis said :)

@benfrain

This comment has been minimized.

Show comment
Hide comment
@benfrain

benfrain Nov 7, 2013

I've just added a bounty for this. I like to think it will buy those involved a beer/hot beverage/cocktail of choice whenever this gets finished. https://www.bountysource.com/issues/1057456-extend-classes-wont-compile-correctly-with-both-regular-and-silent-selectors/bounties

benfrain commented Nov 7, 2013

I've just added a bounty for this. I like to think it will buy those involved a beer/hot beverage/cocktail of choice whenever this gets finished. https://www.bountysource.com/issues/1057456-extend-classes-wont-compile-correctly-with-both-regular-and-silent-selectors/bounties

@emagnier

This comment has been minimized.

Show comment
Hide comment
@emagnier

emagnier Dec 4, 2013

I also added a bounty for this one. Hope this will help :)

emagnier commented Dec 4, 2013

I also added a bounty for this one. Hope this will help :)

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Dec 4, 2013

Working on the feature right now. 100% compatibility with Ruby Sass's @extend implementation is a monumental task, but I think I can at least address the specific use-cases in these tickets before the holidays.

akhleung commented Dec 4, 2013

Working on the feature right now. 100% compatibility with Ruby Sass's @extend implementation is a monumental task, but I think I can at least address the specific use-cases in these tickets before the holidays.

@emagnier

This comment has been minimized.

Show comment
Hide comment
@emagnier

emagnier Dec 4, 2013

Cool, that's great news! Thanks for all the hard work!

emagnier commented Dec 4, 2013

Cool, that's great news! Thanks for all the hard work!

@dansowter

This comment has been minimized.

Show comment
Hide comment
@dansowter

dansowter Jan 3, 2014

Really appreciate the hard work on this, guys. I'm porting over https://github.com/net-engine/trove to use libsass, and this seems to be one of the last issues.

Really appreciate the hard work on this, guys. I'm porting over https://github.com/net-engine/trove to use libsass, and this seems to be one of the last issues.

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Jan 6, 2014

Okay, the two examples given are now working correctly on the @extend branch, which I'll try to merge in a couple of days.

This is not to say that the feature is done -- far from it! I'm just trying to get it working one chunk at a time.

akhleung commented Jan 6, 2014

Okay, the two examples given are now working correctly on the @extend branch, which I'll try to merge in a couple of days.

This is not to say that the feature is done -- far from it! I'm just trying to get it working one chunk at a time.

@jrabbe

This comment has been minimized.

Show comment
Hide comment
@jrabbe

jrabbe Jan 6, 2014

@akhleung is there a branch I can try to see if it works with our Sass?

jrabbe commented Jan 6, 2014

@akhleung is there a branch I can try to see if it works with our Sass?

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Jan 6, 2014

The new code is in the @extend branch. It's a bit messy, but it you should be able to build it with the default makefile (I haven't updated the automake stuff yet).

akhleung commented Jan 6, 2014

The new code is in the @extend branch. It's a bit messy, but it you should be able to build it with the default makefile (I haven't updated the automake stuff yet).

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Jan 7, 2014

Sorry to introduce some noise to the ticket comments but I just wanted to give thanks to @akhleung for the hard work.

lmartins commented Jan 7, 2014

Sorry to introduce some noise to the ticket comments but I just wanted to give thanks to @akhleung for the hard work.

@icasteleyn

This comment has been minimized.

Show comment
Hide comment
@icasteleyn

icasteleyn Jan 8, 2014

Just wanted to add another example where @extends doesn't work properly.
".Sub.myInherit" should be ".myInherit.Sub"

Scss

.myBase { 
    text-decoration: none; 
}

.myInherit{
    @extend .myBase;
    line-height: 1.6;
}

.myBase.Sub{
    color: #123456;
}

SassLib

.myBase, .myInherit {
  text-decoration: none; }

.myInherit {
  line-height: 1.6; }

.myBase.Sub, .Sub.myInherit {
  color: #123456; }

Ruby Sass

.myBase, .myInherit {
  text-decoration: none; }

.myInherit {
  line-height: 1.6; }

.myBase.Sub, .myInherit.Sub {
  color: #123456; }

Just wanted to add another example where @extends doesn't work properly.
".Sub.myInherit" should be ".myInherit.Sub"

Scss

.myBase { 
    text-decoration: none; 
}

.myInherit{
    @extend .myBase;
    line-height: 1.6;
}

.myBase.Sub{
    color: #123456;
}

SassLib

.myBase, .myInherit {
  text-decoration: none; }

.myInherit {
  line-height: 1.6; }

.myBase.Sub, .Sub.myInherit {
  color: #123456; }

Ruby Sass

.myBase, .myInherit {
  text-decoration: none; }

.myInherit {
  line-height: 1.6; }

.myBase.Sub, .myInherit.Sub {
  color: #123456; }
@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Jan 8, 2014

Interesting; I'll look into why the order gets mixed up. (At least the output is still semantically correct, if I'm not mistaken.)

akhleung commented Jan 8, 2014

Interesting; I'll look into why the order gets mixed up. (At least the output is still semantically correct, if I'm not mistaken.)

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Jan 8, 2014

Oh, also, I should mention that I've merged what I have so far into master, so @extend should work a little better than before.

akhleung commented Jan 8, 2014

Oh, also, I should mention that I've merged what I have so far into master, so @extend should work a little better than before.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Feb 3, 2014

Another test case (taken - and simplified - from our code base):

.common {
    color: red;
}
.outer {
    .inner {
        @extend .common;
    }
}
.outer2 {
    @extend .outer;
}

Correct output by Ruby Sass:

.common, .outer .inner, .outer2 .inner {
  color: red; }

libsass output:

.common, .outer .inner, .outer2 {
  color: red; }

The .inner part gets cut out.

mgol commented Feb 3, 2014

Another test case (taken - and simplified - from our code base):

.common {
    color: red;
}
.outer {
    .inner {
        @extend .common;
    }
}
.outer2 {
    @extend .outer;
}

Correct output by Ruby Sass:

.common, .outer .inner, .outer2 .inner {
  color: red; }

libsass output:

.common, .outer .inner, .outer2 {
  color: red; }

The .inner part gets cut out.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Feb 3, 2014

And another, incorrect test case that gets properly shouted at by Ruby Sass:

.common {
    color: red;
}
.outer {
    .inner {
        @extend .common;
    }
}
.outer2 {
    @extend .middle;
}

(notice mismatched @extend .middle)

Ruby Sass gives:

Syntax error: ".outer2" failed to @extend ".middle".
              The selector ".middle" was not found.
              Use "@extend .middle !optional" if the extend should be able to fail.
        on line 10 of test.scss
  Use --trace for backtrace.

whereas libsass happily compiles that to the following:

.common, .outer .inner {
  color: red; }

Is there a proper place to report such issues? I have about 230 mismatched rules compared to the Ruby output, I can provide test cases but maybe it's not worth giving them all since many will be fixed when those already provided are fixed.

mgol commented Feb 3, 2014

And another, incorrect test case that gets properly shouted at by Ruby Sass:

.common {
    color: red;
}
.outer {
    .inner {
        @extend .common;
    }
}
.outer2 {
    @extend .middle;
}

(notice mismatched @extend .middle)

Ruby Sass gives:

Syntax error: ".outer2" failed to @extend ".middle".
              The selector ".middle" was not found.
              Use "@extend .middle !optional" if the extend should be able to fail.
        on line 10 of test.scss
  Use --trace for backtrace.

whereas libsass happily compiles that to the following:

.common, .outer .inner {
  color: red; }

Is there a proper place to report such issues? I have about 230 mismatched rules compared to the Ruby output, I can provide test cases but maybe it's not worth giving them all since many will be fixed when those already provided are fixed.

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Feb 3, 2014

@mzgol @extend is still under active development, and I'm testing against the ~250 or so cases in the Ruby implementation, so it's probably not necessary for you to copy your broken cases here (unless you feel that it's something really unusual). Thanks!

akhleung commented Feb 3, 2014

@mzgol @extend is still under active development, and I'm testing against the ~250 or so cases in the Ruby implementation, so it's probably not necessary for you to copy your broken cases here (unless you feel that it's something really unusual). Thanks!

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Feb 3, 2014

@akhleung OK, thanks for the info! Do you think the implementation requires a lot more work? Not pushing, just curious if we have to wait a little longer.

Anyway, you're doing awesome job here, I bumped the bounty. :)

mgol commented Feb 3, 2014

@akhleung OK, thanks for the info! Do you think the implementation requires a lot more work? Not pushing, just curious if we have to wait a little longer.

Anyway, you're doing awesome job here, I bumped the bounty. :)

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung Feb 3, 2014

It's hard to say for sure, but I think @extend will still require a lot more effort -- that single feature has turned out to be much more sophisticated and subtle than I ever would have imagined when we started this project! Fortunately, @nex3 was kind enough to write up a description of his algorithm, and I've been reading the Ruby source as well, so I hope to get it all figured out in a month or two (depending on how much time I'm able to devote to this project, of course).

akhleung commented Feb 3, 2014

It's hard to say for sure, but I think @extend will still require a lot more effort -- that single feature has turned out to be much more sophisticated and subtle than I ever would have imagined when we started this project! Fortunately, @nex3 was kind enough to write up a description of his algorithm, and I've been reading the Ruby source as well, so I hope to get it all figured out in a month or two (depending on how much time I'm able to devote to this project, of course).

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 4, 2014

If anyone is looking for a summary of issues I encountered with libsass' version of extends, please see this post.

akhleung has an amazing undertaking, we appreciate all your work in this regard.

ghost commented Feb 4, 2014

If anyone is looking for a summary of issues I encountered with libsass' version of extends, please see this post.

akhleung has an amazing undertaking, we appreciate all your work in this regard.

@am11 am11 referenced this issue in madskristensen/WebEssentials2013 Feb 5, 2014

Closed

Sass @extend Pseudo Class Issue #622

@benfrain

This comment has been minimized.

Show comment
Hide comment
@benfrain

benfrain Oct 3, 2014

Brilliant. Just checked my mail and I opened the bounty on the 7th Nov 2013! It sounded like a Herculean task so Its great to see it finally closed after all these months. Great work all involved.

Can't wait to use it in the wild :)

On 3 Oct 2014, at 18:22, Hampton Catlin notifications@github.com wrote:

A year after its opening... I'm ridiculously, incredibly excited to click the close button on this issue. Thanks to @uberska @jaddessi and @michaek this mega-extends-issue can now be closed. The original test case now passes, as do many, many, many, many other new ones written by the team at @DealerDotCom. Also, super thanks to @paulirish for funding the bounty on this and never letting us forget that this was pending. So, @uberska what are you going to do with the bounty? ;)


Reply to this email directly or view it on GitHub.

benfrain commented Oct 3, 2014

Brilliant. Just checked my mail and I opened the bounty on the 7th Nov 2013! It sounded like a Herculean task so Its great to see it finally closed after all these months. Great work all involved.

Can't wait to use it in the wild :)

On 3 Oct 2014, at 18:22, Hampton Catlin notifications@github.com wrote:

A year after its opening... I'm ridiculously, incredibly excited to click the close button on this issue. Thanks to @uberska @jaddessi and @michaek this mega-extends-issue can now be closed. The original test case now passes, as do many, many, many, many other new ones written by the team at @DealerDotCom. Also, super thanks to @paulirish for funding the bounty on this and never letting us forget that this was pending. So, @uberska what are you going to do with the bounty? ;)


Reply to this email directly or view it on GitHub.

@andrewdc

This comment has been minimized.

Show comment
Hide comment
@andrewdc

andrewdc Oct 3, 2014

Fantastic news. This issue was a major blocker for a smacss/bem approach
our team is using. Thanks to everyone who worked on this.
On Oct 3, 2014 10:22 AM, "Hampton Catlin" notifications@github.com wrote:

A year after its opening... I'm ridiculously, incredibly excited to click
the close button on this issue. Thanks to @uberska
https://github.com/uberska @jaddessi https://github.com/jaddessi and
@michaek https://github.com/michaek this mega-extends-issue can now be
closed. The original test case now passes, as do many, many, many, many
other new ones written by the team at @DealerDotCom
https://github.com/dealerdotcom. Also, super thanks to @paulirish
https://github.com/paulirish for funding the bounty on this and never
letting us forget that this was pending. So, @uberska
https://github.com/uberska what are you going to do with the bounty? ;)


Reply to this email directly or view it on GitHub
#146 (comment).

andrewdc commented Oct 3, 2014

Fantastic news. This issue was a major blocker for a smacss/bem approach
our team is using. Thanks to everyone who worked on this.
On Oct 3, 2014 10:22 AM, "Hampton Catlin" notifications@github.com wrote:

A year after its opening... I'm ridiculously, incredibly excited to click
the close button on this issue. Thanks to @uberska
https://github.com/uberska @jaddessi https://github.com/jaddessi and
@michaek https://github.com/michaek this mega-extends-issue can now be
closed. The original test case now passes, as do many, many, many, many
other new ones written by the team at @DealerDotCom
https://github.com/dealerdotcom. Also, super thanks to @paulirish
https://github.com/paulirish for funding the bounty on this and never
letting us forget that this was pending. So, @uberska
https://github.com/uberska what are you going to do with the bounty? ;)


Reply to this email directly or view it on GitHub
#146 (comment).

@blackfalcon

This comment has been minimized.

Show comment
Hide comment
@blackfalcon

blackfalcon Oct 3, 2014

Congrats to everyone all around! This is the final step we needed to move forward and have the community build more trust in this version of the language.

libsass is ready for primetime! I am calling it!

Congrats to everyone all around! This is the final step we needed to move forward and have the community build more trust in this version of the language.

libsass is ready for primetime! I am calling it!

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Oct 3, 2014

Member

Huge thanks to all the supporters on Bountysource! $2000 was raised for this feature! whoa.
Thanks to photoshelter.com via @Westbrook who contributed $1000 of that!

And big ups to @DealerDotCom who sponsored @uberska's development time on the project. Awesome work, everyone.

Member

paulirish commented Oct 3, 2014

Huge thanks to all the supporters on Bountysource! $2000 was raised for this feature! whoa.
Thanks to photoshelter.com via @Westbrook who contributed $1000 of that!

And big ups to @DealerDotCom who sponsored @uberska's development time on the project. Awesome work, everyone.

@Westbrook

This comment has been minimized.

Show comment
Hide comment
@Westbrook

Westbrook Oct 3, 2014

A bit of cheer went up around the office today when this came in. Many thanks @uberaka and @DealerDotCom for making this a reality.

We're super stoked for the possibilities this opens up for the LibSass community at large and are already working to get this into our stack so we can see it in our production code as soon as possible!

On Oct 3, 2014, at 5:07 PM, Paul Irish notifications@github.com wrote:

Huge thanks to all the supporters on Bountysource! $2000 was raised for this feature! whoa.
Thanks to photoshelter.com via @Westbrook who contributed $1000 of that!

And big ups to @DealerDotCom who sponsored @uberska's development time on the project. Awesome work,e veryone.


Reply to this email directly or view it on GitHub.

A bit of cheer went up around the office today when this came in. Many thanks @uberaka and @DealerDotCom for making this a reality.

We're super stoked for the possibilities this opens up for the LibSass community at large and are already working to get this into our stack so we can see it in our production code as soon as possible!

On Oct 3, 2014, at 5:07 PM, Paul Irish notifications@github.com wrote:

Huge thanks to all the supporters on Bountysource! $2000 was raised for this feature! whoa.
Thanks to photoshelter.com via @Westbrook who contributed $1000 of that!

And big ups to @DealerDotCom who sponsored @uberska's development time on the project. Awesome work,e veryone.


Reply to this email directly or view it on GitHub.

@thisguychris

This comment has been minimized.

Show comment
Hide comment
@thisguychris

thisguychris Oct 3, 2014

"That said, we're evaluating whether we can squash the remaining 55!"

@michaek Thank you for the brilliant solution! So I just want to ask, did the remaining 55 tests got squashed?

"That said, we're evaluating whether we can squash the remaining 55!"

@michaek Thank you for the brilliant solution! So I just want to ask, did the remaining 55 tests got squashed?

@albell

This comment has been minimized.

Show comment
Hide comment
@albell

albell Oct 3, 2014

Huge thanks to everyone on this. I anticipate that this will cut my day-to-day sit-and-wait-for-compile time massively. Highly appreciated.

albell commented Oct 3, 2014

Huge thanks to everyone on this. I anticipate that this will cut my day-to-day sit-and-wait-for-compile time massively. Highly appreciated.

@restlessdesign

This comment has been minimized.

Show comment
Hide comment
@restlessdesign

restlessdesign Oct 3, 2014

Huge! Thanks to all who helped on this! 🎉 🎉 🎉

Huge! Thanks to all who helped on this! 🎉 🎉 🎉

@jory

This comment has been minimized.

Show comment
Hide comment
@jory

jory Oct 3, 2014

I'd like to add: WOOOOOOOOOOOOOO!

jory commented Oct 3, 2014

I'd like to add: WOOOOOOOOOOOOOO!

@michaek

This comment has been minimized.

Show comment
Hide comment
@michaek

michaek Oct 4, 2014

Contributor

@deezahyn There are now 35 extend tests that fail/error, but they're all rare edge cases, with the exception of 090_test_comma_extendee. That's the syntax that allows @extend a, b; as a shorthand for @extend a; @extend b;.

And please open new issues for those failing tests that turn out to be dealbreakers for you!

Contributor

michaek commented Oct 4, 2014

@deezahyn There are now 35 extend tests that fail/error, but they're all rare edge cases, with the exception of 090_test_comma_extendee. That's the syntax that allows @extend a, b; as a shorthand for @extend a; @extend b;.

And please open new issues for those failing tests that turn out to be dealbreakers for you!

@bonfish

This comment has been minimized.

Show comment
Hide comment
@bonfish

bonfish Oct 4, 2014

Great news! Looking forward for the new version out, making it possible for me to move back from Ruby SASS.

One thing I gon't quite get. @uberska who earned all the praise as a developer - is not part of the Libsass team? And...

And big ups to @DealerDotCom who sponsored @uberska's development time on the project.

... means that this huge task was backed not only by one of the Top three biggest bounties on Bountysource?

bonfish commented Oct 4, 2014

Great news! Looking forward for the new version out, making it possible for me to move back from Ruby SASS.

One thing I gon't quite get. @uberska who earned all the praise as a developer - is not part of the Libsass team? And...

And big ups to @DealerDotCom who sponsored @uberska's development time on the project.

... means that this huge task was backed not only by one of the Top three biggest bounties on Bountysource?

@sintaxi

This comment has been minimized.

Show comment
Hide comment
@sintaxi

sintaxi Oct 5, 2014

This is wonderful. Thanks to all who helped make this happen.

+1 to EOL the Ruby implementation.

sintaxi commented Oct 5, 2014

This is wonderful. Thanks to all who helped make this happen.

+1 to EOL the Ruby implementation.

@jschulte

This comment has been minimized.

Show comment
Hide comment
@jschulte

jschulte Oct 5, 2014

@bonfish Good questions! @DealerDotCom sponsored the development work on this (devoted full time employees to work on it for weeks!) because it is valuable for our development process efficiency. @uberska and @jaddessi had a lot of prior C++ experience, so they did the lion's share of the development work. @michaek and I helped with writing tests, fixing a few bugs and validating their work. It was a really fun project to work on and we're thrilled that it's available for others to enjoy!

jschulte commented Oct 5, 2014

@bonfish Good questions! @DealerDotCom sponsored the development work on this (devoted full time employees to work on it for weeks!) because it is valuable for our development process efficiency. @uberska and @jaddessi had a lot of prior C++ experience, so they did the lion's share of the development work. @michaek and I helped with writing tests, fixing a few bugs and validating their work. It was a really fun project to work on and we're thrilled that it's available for others to enjoy!

@bonfish

This comment has been minimized.

Show comment
Hide comment
@bonfish

bonfish Oct 5, 2014

@jschulte that sounds very inspiring! Thank you so much for your work!

One more question, if I may: is there a list of tests somewhere in the public, that at-extend is still uncapable of passing? Just to get the view of what constructs to evade in advance.

bonfish commented Oct 5, 2014

@jschulte that sounds very inspiring! Thank you so much for your work!

One more question, if I may: is there a list of tests somewhere in the public, that at-extend is still uncapable of passing? Just to get the view of what constructs to evade in advance.

@renaudleo

This comment has been minimized.

Show comment
Hide comment

<3

@antoinelyset

This comment has been minimized.

Show comment
Hide comment

🎉

@dilrajahdan

This comment has been minimized.

Show comment
Hide comment
@dilrajahdan

dilrajahdan Oct 9, 2014

Excellent Work!

Excellent Work!

@pkyeck

This comment has been minimized.

Show comment
Hide comment
@pkyeck

pkyeck Oct 15, 2014

thanks for the hard work. 🎉

@hcatlin which commit closed this issue? I'm still getting wrong output from node-sass although they updated their dependencies some days ago ...

pkyeck commented Oct 15, 2014

thanks for the hard work. 🎉

@hcatlin which commit closed this issue? I'm still getting wrong output from node-sass although they updated their dependencies some days ago ...

@michaek

This comment has been minimized.

Show comment
Hide comment
@michaek

michaek Oct 16, 2014

Contributor

The node-sass project will be doing a release once libsass has its 3.0.0 release. In the meantime, it is possible to build node-sass (and thus use it) following the instructions here: https://github.com/sass/node-sass#rebuilding-binaries That said, it's not exactly for the faint of heart!

Contributor

michaek commented Oct 16, 2014

The node-sass project will be doing a release once libsass has its 3.0.0 release. In the meantime, it is possible to build node-sass (and thus use it) following the instructions here: https://github.com/sass/node-sass#rebuilding-binaries That said, it's not exactly for the faint of heart!

@michaek

This comment has been minimized.

Show comment
Hide comment
@michaek

michaek Oct 17, 2014

Contributor

These are not all relevant to everyone, but the work on this issue has now been released where most consumers can "just use it":

libsass 3.0.0 is released
node-sass 1.0.0 is released
grunt-sass 0.16.0 is released
gulp-sass 1.2.0 is released

Contributor

michaek commented Oct 17, 2014

These are not all relevant to everyone, but the work on this issue has now been released where most consumers can "just use it":

libsass 3.0.0 is released
node-sass 1.0.0 is released
grunt-sass 0.16.0 is released
gulp-sass 1.2.0 is released

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Oct 17, 2014

Member

Impressed with the coordination across projects such they all release the same day! Nice work to @hcatlin and all the maintainers for making this nice for all users. :D

Member

paulirish commented Oct 17, 2014

Impressed with the coordination across projects such they all release the same day! Nice work to @hcatlin and all the maintainers for making this nice for all users. :D

@davecranwell davecranwell referenced this issue in wagtail/wagtail Oct 22, 2014

Closed

Update version of sassc/libsass used #271

@sandstrom

This comment has been minimized.

Show comment
Hide comment
@sandstrom

sandstrom Oct 28, 2014

Awesome!! ⛵️

Awesome!! ⛵️

@gorilas

This comment has been minimized.

Show comment
Hide comment
@gorilas

gorilas Nov 11, 2014

It has been amazing what happened!!!! Thanks to everyone. Hurra y Viva!!!!

gorilas commented Nov 11, 2014

It has been amazing what happened!!!! Thanks to everyone. Hurra y Viva!!!!

@jbeja

This comment has been minimized.

Show comment
Hide comment
@jbeja

jbeja Nov 13, 2014

Omg, I can't believe this is finally solve. Thanks to everyone from the bottom of my heart <3.

jbeja commented Nov 13, 2014

Omg, I can't believe this is finally solve. Thanks to everyone from the bottom of my heart <3.

@ldexterldesign

This comment has been minimized.

Show comment
Hide comment
@ldexterldesign

ldexterldesign Dec 3, 2014

Apologies for the noise folks, but hoping someone will more knowledge can help me?:
sindresorhus/grunt-sass#162

Yours hopefully,

Apologies for the noise folks, but hoping someone will more knowledge can help me?:
sindresorhus/grunt-sass#162

Yours hopefully,

@dreamyguy

This comment has been minimized.

Show comment
Hide comment
@dreamyguy

dreamyguy Dec 3, 2014

Just had to say my thanks to this fix! Life-saver, just in time! ❤️

Just had to say my thanks to this fix! Life-saver, just in time! ❤️

@quis quis referenced this issue in alphagov/govuk_frontend_toolkit Dec 8, 2014

Merged

Add note to readme about incompatible Libsass versions #153

anlutro pushed a commit to alprs/libsass that referenced this issue Feb 2, 2015

Merge pull request #146 from mgreter/master
Add spec test for issue #666 (convert angles)

@FMCorz FMCorz referenced this issue in ionic-team/ionic-cli Feb 3, 2015

Closed

Sass does not support @extend #217

@hcatlin hcatlin changed the title from Extended selectors wont compile correctly (with both regular and silent selectors) [$2,000] to Extended selectors wont compile correctly (with both regular and silent selectors) [$2,000 awarded] Feb 21, 2015

@downzer0 downzer0 referenced this issue in edx/ux-pattern-library Jun 15, 2015

Closed

Elements: Forms and form controls #75

@mgreter mgreter removed the bounty label Oct 22, 2016

@hcatlin hcatlin added the bounty label Dec 29, 2016

@hcatlin hcatlin changed the title from Extended selectors wont compile correctly (with both regular and silent selectors) [$2,000 awarded] to Extended selectors wont compile correctly (with both regular and silent selectors) Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment