Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate #RRGGBBAA and #RGBA id parsing #2302

Closed
xzyfer opened this issue Jan 18, 2017 · 0 comments
Closed

Deprecate #RRGGBBAA and #RGBA id parsing #2302

xzyfer opened this issue Jan 18, 2017 · 0 comments
Assignees
@xzyfer
Labels
Dev - PR Ready Dev - Test Written Sass 3.5
Milestone
3.5.0.beta.4

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jan 18, 2017 •
edited by HamptonMakes

Values that can be interpreted as hex colors with alpha channels and also as ID values, such as #abcd, now emit deprecation warnings in preparation for being parsed differently Sass 3.6. They were previously parsed as strings, and in 3.6 they will be parsed as colors instead.

Issue sass/sass/pull/2179
PR sass/sass/pull/2226
Spec sass/sass-spec#1063
@xzyfer xzyfer added this to the 3.5 milestone Jan 18, 2017
xzyfer added a commit to xzyfer/libsass that referenced this issue Apr 20, 2017
@xzyfer
Produce a deprecation warning for ID strings that look like colors
6169872 
Fixes sass#2302
Spec sass/sass-spec#1099
@xzyfer xzyfer self-assigned this Apr 20, 2017
@xzyfer xzyfer mentioned this issue Apr 20, 2017
Merged
xzyfer added a commit to xzyfer/libsass that referenced this issue Apr 20, 2017
@xzyfer
Produce a deprecation warning for ID strings that look like colors
aa30075 
Fixes sass#2302
Spec sass/sass-spec#1099
xzyfer added a commit that referenced this issue Apr 22, 2017
@xzyfer
Produce a deprecation warning for ID strings that look like colors (#…
4462a55 
…2361)

* Make the deprecation function more generic

* Produce a deprecation warning for ID strings that look like colors

Fixes #2302
Spec sass/sass-spec#1099
@xzyfer xzyfer modified the milestones: 3.5.0.beta.4, 3.5 Apr 22, 2017
@nex3 nex3 mentioned this issue Jun 21, 2018
Closed
xzyfer added a commit to xzyfer/libsass that referenced this issue Jul 26, 2018
@xzyfer
Support hex colors with alpha channels
5722326 
A deprecation for the old behaviour landed in sass#2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273
xzyfer added a commit to xzyfer/libsass that referenced this issue Jul 26, 2018
@xzyfer
Support hex colors with alpha channels
b2d6ed5 
A deprecation for the old behaviour landed in sass#2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273

Fixes sass#2674
@xzyfer xzyfer mentioned this issue Jul 26, 2018
Merged
xzyfer added a commit that referenced this issue Jul 26, 2018
@xzyfer
Support hex colors with alpha channels
fbdcc37 
A deprecation for the old behaviour landed in #2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273

Fixes #2674
xzyfer added a commit that referenced this issue Nov 11, 2018
@xzyfer
Support hex colors with alpha channels
7459d19 
A deprecation for the old behaviour landed in #2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273

Fixes #2674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzyfer xzyfer

Labels
Dev - PR Ready Dev - Test Written Sass 3.5
Projects
None yet
Milestone
3.5.0.beta.4
Development

No branches or pull requests
1 participant
@xzyfer