:not() clause ignored completely

[adamreisnz]

This has started failing once we updated gulp-sass which indirectly updated libsass to 3.5.4.

input.scss

.Card {
  &:not(.is-open, .is-static) {
    .CardContents {
      display: none;
    }
  }
}

Actual results

libsass 3.5.3

.Card .CardContents {
    display: none;
}

Expected result

E.g. DartSass 1.6.2, Sass 3.5.6:

.Card:not(.is-open, .is-static) .CardContents {
  display: none;
}

version info: I don't have the CLI versions installed to output the version, as we're using gulp-sass. But the problem is easily reproducible with libsass.ocbnet.ch or sassmeister.com.

[adamreisnz]

I happened to pick up on this issue, but it makes me worried what else might not be working correctly in the latest libsass versions. We use :not selectors and & references quite extensively.

[mbehzad]

i'm having the same issue.
:not(.c1, .c2)
or
&:not(.c1)
will work correctly. but
&:not(.c1, .c2)
will result to a rule with no :not in it.

[adamreisnz]

Would be great to get some feedback on this from a collaborator.

[JoanBotella]

I have the same problem. I'm using the LibSass v3.5.4 .

Note that you can still use the syntax :not(.foo):not(.bar) .

[adamreisnz]

@xzyfer Any update on this guys? This is a severe bug, why is it not being addressed?
Valid code that was working before is no longer working, forcing us to stay on v2.

I've added steps to reproduce etc.

[adamreisnz]

Awesome, thanks for fixing

[adamreisnz]

@glebm What version of libsass did this fix end up in?

[xzyfer]

No release yet.

…

On Mon., 3 Dec. 2018, 9:18 am Adam Reis ***@***.*** wrote: @glebm <https://github.com/glebm> What version of libsass did this fix end up in? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2697 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWDnKPNqM6h2Ud4cFdZphcv8lsM-Nks5u1FGtgaJpZM4VcKvK> .

[adamreisnz]

Do you have an estimate for when it might be released?

We are having issues installing our build tools on a windows computer because we're forced to use a lower version of node-sass which doesn't have this bug. Would be great if we could upgrade the whole stack.

[xzyfer]

No plans yet. We need to wait for the current churn to slow down so that we can do QA. A release now could potentially introduce new regressions.

…

On Mon., 3 Dec. 2018, 9:30 am Adam Reis ***@***.*** wrote: Do you have an estimate for when it might be released? We are having issues installing our build tools on a windows computer because we're forced to use a lower version of node-sass which doesn't have this bug. Would be great if we could upgrade the whole stack. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2697 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWCfSVEk8jPePe0AYREaOWfcAEP0hks5u1FSdgaJpZM4VcKvK> .

[ILyaCyclone]

Any plans for fixing this issue in release? We are stuck on "gulp-sass": "^2.3.2" (in which there's no such issue) and can't upgrade.