Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source isn't "go gettable" #3055

Closed
bep opened this issue Feb 8, 2020 · 6 comments
Closed

Source isn't "go gettable" #3055

bep opened this issue Feb 8, 2020 · 6 comments

Comments

@bep
Copy link
Contributor

@bep bep commented Feb 8, 2020

I try to embed this repo's source as a Git subtree in a Go Module. Go complains:

-> unzip /Users/bep/go/pkg/mod/cache/download/github.com/bep/golibsass/@v/v0.1.0.zip: malformed file path "libsass_src/test/e2e/unicode-pwd/Sáss-UŢF8/input.scss": invalid char '́'
go get github.com/bep/golibsass: unzip /Users/bep/go/pkg/mod/cache/download/github.com/bep/golibsass/@v/v0.1.0.zip: malformed file path "libsass_src/test/e2e/unicode-pwd/Sáss-UŢF8/input.scss": invalid char '́'

I can get passed this short term by deleting this folder, but I would appreciate a fix for this (I would suggest you generate these folders as part of the test run). I assume other unzip tools will also have problems with your source distribution.

bep added a commit to bep/golibsass that referenced this issue Feb 8, 2020
@nschonni

This comment has been minimized.

Copy link
Collaborator

@nschonni nschonni commented Feb 8, 2020

Those tests are to ensure compatibility with unicode files. You're running into the issue because the library that is unzipping or maybe Go's package manager isn't unicode aware. I don't think this is something that will be changed here to workaround that.

PS: we also subtree libsass into node-sass and don't have this issue

@bep

This comment has been minimized.

Copy link
Contributor Author

@bep bep commented Feb 8, 2020

You're running into the issue because the library that is unzipping or maybe Go's package manager isn't unicode aware. I don't think this is something that will be changed here to workaround that.

I'm pretty sure Go is plenty Unicode aware. I will try to raise an issue on the Go tracker about this, but since the application I'm bulding, Hugo, has a "current and current-1" Go version policy it will be, at the best, fixed in a year or so. It would be unfortunate if Go LibSass clients would be stuck with LibSass 3.5.5 because of some test files.

@bep

This comment has been minimized.

Copy link
Contributor Author

@bep bep commented Feb 10, 2020

PS: we also subtree libsass into node-sass and don't have this issue

node-sass includes a fairly old version of LibSass without these files.

My issue on the Go tracker has been closed/rejected, see golang/go#37139 (comment)

@bcmills

This comment has been minimized.

Copy link

@bcmills bcmills commented Feb 10, 2020

@bep, note that you can prune a subdirectory out of the resulting Go module by adding a (possibly-empty) go.mod file to that subdirectory.

@bep

This comment has been minimized.

Copy link
Contributor Author

@bep bep commented Feb 10, 2020

@bcmills I don't want to do any edits to the libsass_src dir so people can if they want, verify that the libsass version used is what I claim.

@xzyfer

This comment has been minimized.

Copy link
Contributor

@xzyfer xzyfer commented Feb 11, 2020

We'd be open to a pr to add a go.mod that would make LibSass go get-able.

@bep bep changed the title Fails to unzip the source distro Source isn't "go gettable" Feb 11, 2020
bep added a commit to bep/libsass that referenced this issue Feb 13, 2020
To make this project "go gettable".

Clses sass#3055
xzyfer pushed a commit that referenced this issue Feb 13, 2020
To make this project "go gettable".

Clses #3055
@bep bep closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.