New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline (loud) comments removed in compressed outputStyle #348

Closed
strangerpixel opened this Issue May 1, 2014 · 7 comments

Comments

Projects
None yet
7 participants
@strangerpixel

strangerpixel commented May 1, 2014

It seems as though multiline comments i.e. /* Multiline comment */ - although normally preserved in SASS output when generated via Compass - are stripped out when using 'compressed' outputStyle in grunt-sass?

@nschonni

This comment has been minimized.

Show comment
Hide comment
@nschonni

nschonni May 1, 2014

Collaborator

See http://sass-lang.com/documentation/file.SASS_REFERENCE.html#comments as only loud comments (/*! */) survive the compressed version

Collaborator

nschonni commented May 1, 2014

See http://sass-lang.com/documentation/file.SASS_REFERENCE.html#comments as only loud comments (/*! */) survive the compressed version

@strangerpixel

This comment has been minimized.

Show comment
Hide comment
@strangerpixel

strangerpixel May 1, 2014

I've tried loud comments but they don't output either. I believe this may relate to #291 - in which case I guess I can override the version of libsass in grunt-sass?

strangerpixel commented May 1, 2014

I've tried loud comments but they don't output either. I believe this may relate to #291 - in which case I guess I can override the version of libsass in grunt-sass?

@strangerpixel strangerpixel changed the title from Multiline comments removed in compressed outputStyle to Multiline (loud) comments removed in compressed outputStyle May 1, 2014

@akhleung

This comment has been minimized.

Show comment
Hide comment
@akhleung

akhleung May 1, 2014

Sorry, I didn't realize that loud comments were a separate thing until this issue got filed! Compressed mode will currently strip all comments.

akhleung commented May 1, 2014

Sorry, I didn't realize that loud comments were a separate thing until this issue got filed! Compressed mode will currently strip all comments.

@hilja

This comment has been minimized.

Show comment
Hide comment
@hilja

hilja May 1, 2014

Loud comment would be amazing, WordPress want's to have a theme declaration in the CSS file as a comment.

hilja commented May 1, 2014

Loud comment would be amazing, WordPress want's to have a theme declaration in the CSS file as a comment.

@iodic

This comment has been minimized.

Show comment
Hide comment
@iodic

iodic May 16, 2014

👍 for loud comments. I am using libsass in CodeKit and also need loud comments for WordPress themes. :)

iodic commented May 16, 2014

👍 for loud comments. I am using libsass in CodeKit and also need loud comments for WordPress themes. :)

@sethta

This comment has been minimized.

Show comment
Hide comment
@sethta

sethta May 24, 2014

+1 also for loud comments. As mentioned earlier, it's needed for WordPress themes.

sethta commented May 24, 2014

+1 also for loud comments. As mentioned earlier, it's needed for WordPress themes.

wonja added a commit to wonja/libsass that referenced this issue Jun 4, 2014

@wonja wonja referenced this issue Jun 4, 2014

Merged

Loud comments #378

@akhleung akhleung closed this in #378 Jun 4, 2014

@jonmspencer

This comment has been minimized.

Show comment
Hide comment
@jonmspencer

jonmspencer Apr 24, 2015

+1 Keep loud comments!

jonmspencer commented Apr 24, 2015

+1 Keep loud comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment