New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sass 3.3 scoping #613

Closed
xzyfer opened this Issue Nov 3, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@xzyfer
Contributor

xzyfer commented Nov 3, 2014

Following on from #278 opening this issue to track work on the new scoping model.

Although the Libsass changeset should be easy enough, sass-spec will probably need some significant work.

@HugoGiraudel

This comment has been minimized.

HugoGiraudel commented Dec 11, 2014

Added a spec: sass/sass-spec#169.

@mgreter

This comment has been minimized.

Contributor

mgreter commented Jan 4, 2015

As a side note: A proper implementation should release the memory of the variable as soon as it goes out of scope (I guess we don't have to deal with references and counting). AFAIK my last tests showed that ruby sass also does not do this, and libsass of course neither yet! This could IMO lead to potential DOS, since a simple very big @for loop will allocate at least one additional variable on each iteration. I thought about a memory limit for [ctx.mem] allocations, but for that we would need to have stats about all allocated memory sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment