Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Early preview of dart-sass parser backport #2918

Open
wants to merge 2 commits into
base: master
from

Conversation

@mgreter
Copy link
Contributor

mgreter commented Jun 22, 2019

Needs sass/sass-spec#1425

Please don't review, only leaving this here since I don't know when I'll have time to finish this up.
My vacations are over soon, so I don't know when I'll get around to complete this.
It's already semi usable, passing 80% of current spec tests.
Tried to preserve current libsass behavior, but
probably needs changes in eval stage too!
All the debug glory is still in the code!

Edit: I started to bring back some stuff to master in order to make this change a little bit smaller.
I also tagged all open issues that should be fixed by this backport/refactoring (ATM 76/120).

@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 6 times, most recently from 3172461 to 95bedc6 Jul 8, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Jul 9, 2019

Current state: 26 specs with (mostly minor) regressions, 122 newly passing

@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 5 times, most recently from 3923e61 to 6835c29 Jul 10, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Jul 15, 2019

Current state: all specs passing with around 150 newly passing

Ported scss, sass and css parser.
Lot of stuff still to do; most obvious:

  • ParserStates for sourcemaps
  • And correct error reporting
  • Cleanup of import classes

Master: 3062 runs, 0 assertions, 0 failures, 0 errors, 829 skips
Branch: 3725 runs, 0 assertions, 0 failures, 0 errors, 748 skips

@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 7 times, most recently from 98e8d55 to 4613f3e Jul 15, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Jul 20, 2019

Current state: 3906 runs, 0 assertions, 0 failures, 0 errors, 752 skips

@xzyfer

This comment has been minimized.

Copy link
Contributor

xzyfer commented Jul 20, 2019

@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch from 34059f0 to abebb51 Jul 20, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Jul 21, 2019

@xzyfer Don't expect anything to land before winter.
I guess this should land for a 3.8 version (close to sass 4.0).

@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch from 5b17a56 to 3de51e9 Jul 21, 2019
@mgreter mgreter added the LibSass 3.8 label Jul 21, 2019
@mgreter mgreter self-assigned this Jul 21, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Aug 7, 2019

Current state: 3906 runs, 0 assertions, 0 failures, 0 errors, 147 skips.

  • Removed deprecated color arithmetic
  • Removed quoted/constant string ambiguity
  • Removed overly complex binary op eval stuff.
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 2 times, most recently from 7478fb7 to bcd5056 Aug 7, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Aug 28, 2019

Fixed the HRX files so we should at least get a result now (expecting a few memory leaks)

@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Aug 28, 2019

Current stats: 4116 runs, 0 assertions, 13 failures, 0 errors, 168 skips
7 Failures are from the new superselector tests (which we didn't pass before anyway).
The rest are diffs in error messages (mostly from recursive/cylcic includes).
With the new spec we should be able to test the full call stack instead of only the first line.

@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch from 0acee20 to ded53fc Aug 31, 2019
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 7 times, most recently from 46ee11c to 5e345c0 Sep 15, 2019
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch from 3b38d57 to 993d5a7 Oct 2, 2019
@mgreter mgreter added LibSass 4.0 and removed LibSass 3.8 labels Nov 8, 2019
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 2 times, most recently from 45b1e0b to f1cfd65 Nov 8, 2019
@mgreter mgreter changed the title [WIP] Ultra early preview of dart-sass parser backport [WIP] Early preview of dart-sass parser backport Nov 15, 2019
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch from 57cddb1 to b0ab13c Nov 15, 2019
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch from b0ab13c to 32c6925 Nov 24, 2019
@mgreter mgreter force-pushed the mgreter:feature/backport-parser branch 4 times, most recently from 2fbe0e0 to 1c35cbc Dec 14, 2019
@mgreter

This comment has been minimized.

Copy link
Contributor Author

mgreter commented Dec 14, 2019

Current stats: 4143 runs, 0 assertions, 0 failures, 0 errors, 148 skips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.