Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--forward=prefixed should work if the prefix was removed by a previous migrator run #123

Closed
jathak opened this issue Nov 1, 2019 · 0 comments · Fixed by #124

Comments

@jathak
Copy link
Member

@jathak jathak commented Nov 1, 2019

For a case like:

// entrypoint.scss
@import "library";

// _library.scss
$variable: green;

// _library.import.scss
@forward "library" as lib-*;

running the migrator with --remove-prefix=lib- --forward=prefixed should still forward $variable, since it was previously prefixed within entrypoint.scss, but since this prefix was already removed when _library.scss was migrated, this isn't detected.

jathak added a commit that referenced this issue Nov 4, 2019
Fixes #123.

If a member was unprefixed by a previous migrator run, running the
migrator on a downstream stylesheet with `--forward=prefixed` should
still forward that member.
@jathak jathak closed this in #124 Nov 5, 2019
jathak added a commit that referenced this issue Nov 5, 2019
* Support --forward=prefixed across migrator runs

Fixes #123.

If a member was unprefixed by a previous migrator run, running the
migrator on a downstream stylesheet with `--forward=prefixed` should
still forward that member.

* Add additional test

* Support subprefixes

* Code review + fix bug test revealed

References should now take prefixes into account when checking a
member's visibility in a `@forward` rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.