Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load members from load paths and node_modules using original URLs #103

Merged
merged 3 commits into from Oct 1, 2019

Conversation

@nex3
Copy link
Contributor

commented Oct 1, 2019

Rather than loading the stylesheets in which these members were literally
defined, load stylesheets that transitively import those stylesheets. Since
we aren't migrating these files, the transitive imports will continue to
work, and this avoids potentially importing from within a package's private
filesystem structure.

@nex3 nex3 requested a review from jathak Oct 1, 2019
@nex3 nex3 force-pushed the one-library-use branch from b82585d to b1ef403 Oct 1, 2019
nex3 added 3 commits Oct 1, 2019
Rather than loading the stylesheets in which these members were
literally defined, load stylesheets that transitively import those
stylesheets. Since we aren't migrating these files, the transitive
imports will continue to work, and this avoids potentially importing
from within a package's private filesystem structure.
This reverts commit 5eec0d8. This is
no longer necessary now that we're loading transitive third-party
imports from the original third-party import URL.
This reverts commit 632c6ce. This is
no longer needed now that we aren't using these imports to
decanonicalize URLs.
@nex3 nex3 force-pushed the one-library-use branch from d523b07 to e151498 Oct 1, 2019
@jathak
jathak approved these changes Oct 1, 2019
@nex3 nex3 changed the base branch from stop-at-load-path to master Oct 1, 2019
@nex3 nex3 merged commit de05f12 into master Oct 1, 2019
@nex3 nex3 deleted the one-library-use branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.