Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only migrate config variables from upstream files #113

Merged
merged 2 commits into from Oct 10, 2019

Conversation

@jathak
Copy link
Member

commented Oct 8, 2019

Fixes #112.

@jathak jathak requested a review from nex3 Oct 8, 2019
@nex3
nex3 approved these changes Oct 10, 2019
@nex3

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Probably a good idea to add a CHANGELOG entry for this, and bump the minor version in the pubspec.

@jathak jathak force-pushed the externally-configured-fix branch from b941075 to f38623c Oct 10, 2019
@jathak jathak merged commit 08fb490 into master Oct 10, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@jathak jathak deleted the externally-configured-fix branch Oct 10, 2019
@@ -1,5 +1,5 @@
name: sass_migrator
version: 1.0.0
version: 1.0.1

This comment has been minimized.

Copy link
@nex3

nex3 Oct 10, 2019

Contributor

The pattern we used on the Dart team, which I still use on Dart Sass, is to use the -dev suffix for versions that are still in-development and not intended to be released. Notionally this means that the only Git revisions that have non--dev versions are exactly the same as the tagged and published versions. This also helps when collaborating with other people, because they know without checking published venues that if the version is -dev they can add new features without bumping the version further but if it's not they need to bump it.

So 1.0.1 would make sense if you were planning on tagging and publishing immediately, but otherwise you'd want to write 1.0.1-dev.

This comment has been minimized.

Copy link
@jathak

jathak Oct 10, 2019

Author Member

Oh, okay. I'll do that in the future. In this case, I'd like to fix #114 (PR incoming) before publishing 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.