Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs necessary for mdc-web migration #133

Merged
merged 3 commits into from Jan 16, 2020
Merged

Fix bugs necessary for mdc-web migration #133

merged 3 commits into from Jan 16, 2020

Conversation

@jathak
Copy link
Member

jathak commented Jan 16, 2020

This contains two bug fixes that were necessary for material-components/material-components-web#5220:

  • Ensure that all references get renamed when a prefix is removed from a variable that's declared multiple times
  • Sort the @forward rules within import-only files to ensure that configuration via @import still works when a library migrates
jathak added 3 commits Jan 9, 2020
Ensures that variables from indirect dependencies are still configurable
via `@import`.
@jathak jathak requested a review from nex3 Jan 16, 2020
@nex3
nex3 approved these changes Jan 16, 2020
@jathak jathak merged commit f1c0ed9 into master Jan 16, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@jathak jathak deleted the mdc-fixes branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.