Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy steps to Travis #39

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@nex3
Copy link
Contributor

commented May 3, 2019

This doesn't add Homebrew support yet. Homebrew releases are easiest
to do as edits of an existing Homebrew formula, and creating one of
those requires at least one existing release.

Partially addresses #26

Add deploy steps to Travis
This doesn't add Homebrew support yet. Homebrew releases are easiest
to do as edits of an existing Homebrew formula, and creating one of
those requires at least one existing release.

Partially addresses #26

@nex3 nex3 requested a review from jathak May 3, 2019

@nex3

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@jathak I copied this logic from Dart Sass; please make sure I didn't miss any instances where I should have replaced "Sass" with "Sass Migrator" or something similar.

@jathak

jathak approved these changes May 9, 2019

Copy link
Member

left a comment

LGTM, expect for instances of "Sass" mentioned in comments

Show resolved Hide resolved package/sass-migrator.sh Outdated
Show resolved Hide resolved tool/grind/chocolatey.dart Outdated
Show resolved Hide resolved tool/grind/standalone.dart Outdated
Show resolved Hide resolved tool/grind/standalone.dart Outdated
Show resolved Hide resolved package/sass-migrator.bat Outdated
@nex3
Copy link
Contributor Author

left a comment

Thanks, fixed!

@nex3 nex3 merged commit b3e8b9a into master May 14, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@nex3 nex3 deleted the deploy branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.