Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require dependencies in the preamble rather than through JS-interop #67

Merged
merged 1 commit into from Jul 13, 2019

Conversation

Projects
None yet
2 participants
@jathak
Copy link
Member

commented Jul 11, 2019

sass/dart-sass#727 changed the way it depended on the Node fs module, breaking the migrator's use of it.

This changes the JS build script for the migrator to match the new behavior in the sass package.

Require dependencies with preamble, not JS interop
sass/dart-sass#727 changed the way it depended on the Node fs module,
breaking the migrator's use of it.

This changes the JS build script for the migrator to match the new
behavior in the sass package.

@jathak jathak requested a review from nex3 Jul 11, 2019

@nex3

nex3 approved these changes Jul 12, 2019

@jathak jathak merged commit 588bf0d into master Jul 13, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jathak jathak deleted the node-fix branch Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.