Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Code review for existing code #4
This is looking really good! I have a bunch of comments, but most of them are small stylistic stuff. The only big thing is the possibility of switching from
referenced this pull request
Feb 12, 2019
I refactored away
I believe I've addressed most of your comments, aside from more tightly-scoped tests, which I'll work on in a separate branch. Let me know if anything needs clarification. Thanks!